Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: tests/language/operations_on_non_num_operand_test.dart

Issue 1411633002: Generalize and_operation_on_non_int_operand_test. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/and_operation_on_non_integer_operand_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/operations_on_non_num_operand_test.dart
diff --git a/tests/language/operations_on_non_num_operand_test.dart b/tests/language/operations_on_non_num_operand_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..9f990ad371fcd4cb3eefaf5e5ecb87eda2c8075c
--- /dev/null
+++ b/tests/language/operations_on_non_num_operand_test.dart
@@ -0,0 +1,129 @@
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// Regression test for dart2js that used to miscompile boolean and operations
+/// if one of the operands was an int and the other was not (issue 22427).
+///
+/// Extended to all operations as there is a risk of similar bugs with other
+/// operators, e.g. `a % 2` _looks_ like it might be 0 or 1.
+
+import "package:expect/expect.dart";
+
+@AssumeDynamic() @NoInline()
+confuse(x) => x;
+
+class Thing1 {
+ operator&(b) => this;
+ operator|(b) => this;
+ operator^(b) => this;
+ operator<<(b) => this;
+ operator>>(b) => this;
+
+ operator+(b) => this;
+ operator-(b) => this;
+ operator*(b) => this;
+ operator/(b) => this;
+ operator~/(b) => this;
+ operator%(b) => this;
+ remainder(b) => this;
+
+ operator<(b) => this;
+ operator<=(b) => this;
+ operator>(b) => this;
+ operator>=(b) => this;
+}
+
+class Thing2 {
+ @NoInline() operator&(b) => this;
+ @NoInline() operator|(b) => this;
+ @NoInline() operator^(b) => this;
+ @NoInline() operator<<(b) => this;
+ @NoInline() operator>>(b) => this;
+
+ @NoInline() operator+(b) => this;
+ @NoInline() operator-(b) => this;
+ @NoInline() operator*(b) => this;
+ @NoInline() operator/(b) => this;
+ @NoInline() operator~/(b) => this;
+ @NoInline() operator%(b) => this;
+ @NoInline() remainder(b) => this;
+
+ @NoInline() operator<(b) => this;
+ @NoInline() operator<=(b) => this;
+ @NoInline() operator>(b) => this;
+ @NoInline() operator>=(b) => this;
+}
+
+
+confused() {
+ var a = new Thing1();
+ Expect.equals(a, confuse(a) & 5 & 2);
+ Expect.equals(a, confuse(a) | 5 | 2);
+ Expect.equals(a, confuse(a) ^ 5 ^ 2);
+ Expect.equals(a, confuse(a) << 5 << 2);
+ Expect.equals(a, confuse(a) >> 5 >> 2);
+
+ Expect.equals(a, confuse(a) + 5 + 2);
+ Expect.equals(a, confuse(a) - 5 - 2);
+ Expect.equals(a, confuse(a) * 5 * 2);
+ Expect.equals(a, confuse(a) / 5 / 2);
+ Expect.equals(a, confuse(a) % 5 % 2);
+ Expect.equals(a, confuse(a) ~/ 5 ~/ 2);
+ Expect.equals(a, confuse(a).remainder(5).remainder(2));
+
+ Expect.equals(a, (confuse(a) < 5) < 2);
+ Expect.equals(a, (confuse(a) <= 5) <= 2);
+ Expect.equals(a, (confuse(a) > 5) > 2);
+ Expect.equals(a, (confuse(a) >= 5) >= 2);
+}
+
+direct1() {
+ var a = new Thing1();
+ Expect.equals(a, a & 5 & 2);
+ Expect.equals(a, a | 5 | 2);
+ Expect.equals(a, a ^ 5 ^ 2);
+ Expect.equals(a, a << 5 << 2);
+ Expect.equals(a, a >> 5 >> 2);
+
+ Expect.equals(a, a + 5 + 2);
+ Expect.equals(a, a - 5 - 2);
+ Expect.equals(a, a * 5 * 2);
+ Expect.equals(a, a / 5 / 2);
+ Expect.equals(a, a % 5 % 2);
+ Expect.equals(a, a ~/ 5 ~/ 2);
+ Expect.equals(a, a.remainder(5).remainder(2));
+
+ Expect.equals(a, (a < 5) < 2);
+ Expect.equals(a, (a <= 5) <= 2);
+ Expect.equals(a, (a > 5) > 2);
+ Expect.equals(a, (a >= 5) >= 2);
+}
+
+direct2() {
+ var a = new Thing2();
+ Expect.equals(a, a & 5 & 2);
+ Expect.equals(a, a | 5 | 2);
+ Expect.equals(a, a ^ 5 ^ 2);
+ Expect.equals(a, a << 5 << 2);
+ Expect.equals(a, a >> 5 >> 2);
+
+ Expect.equals(a, a + 5 + 2);
+ Expect.equals(a, a - 5 - 2);
+ Expect.equals(a, a * 5 * 2);
+ Expect.equals(a, a / 5 / 2);
+ Expect.equals(a, a % 5 % 2);
+ Expect.equals(a, a ~/ 5 ~/ 2);
+ Expect.equals(a, a.remainder(5).remainder(2));
+
+ Expect.equals(a, (a < 5) < 2);
+ Expect.equals(a, (a <= 5) <= 2);
+ Expect.equals(a, (a > 5) > 2);
+ Expect.equals(a, (a >= 5) >= 2);
+}
+
+main () {
+ confused();
+ direct1();
+ direct2();
+}
« no previous file with comments | « tests/language/and_operation_on_non_integer_operand_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698