Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 141163014: Strip the invalid characters from the string used as mspdbsrv endpoint. (Closed)

Created:
6 years, 11 months ago by Sébastien Marchand
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Strip the invalid characters from the string used as mspdbsrv endpoint. Patch from sebmarchand@chromium.org. R=scottmg@chromium.org BUG=335607 Committed: https://code.google.com/p/gyp/source/detail?r=1840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pylib/gyp/win_tool.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Sébastien Marchand
PTAL.
6 years, 11 months ago (2014-01-17 19:06:41 UTC) #1
scottmg
lgtm Just fix the description/title to "String the invalid characters..."
6 years, 11 months ago (2014-01-17 19:12:34 UTC) #2
scottmg
On 2014/01/17 19:12:34, scottmg wrote: > lgtm > > Just fix the description/title to "String ...
6 years, 11 months ago (2014-01-17 19:12:50 UTC) #3
Sébastien Marchand
Fixed, sorry for that. Can you please land this CL (I still don't have enough ...
6 years, 11 months ago (2014-01-17 19:14:12 UTC) #4
scottmg
Committed patchset #1 manually as r1840 (presubmit successful).
6 years, 11 months ago (2014-01-17 19:19:22 UTC) #5
scottmg
6 years, 11 months ago (2014-01-17 19:19:47 UTC) #6
Message was sent while issue was closed.
On 2014/01/17 19:14:12, Sébastien Marchand wrote:
> Fixed, sorry for that. Can you please land this CL (I still don't have enough
> powers to do this :)

Done, you should probably ping bradn to get committer bit.

Powered by Google App Engine
This is Rietveld 408576698