Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 141163004: Telemetry: Fix frame counting on Mac (Closed)

Created:
6 years, 11 months ago by epenner
Modified:
6 years, 11 months ago
Reviewers:
nduca, ernstm
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: Fix timeline frame counting on Mac We want to count the last the last swap in the embedding chain. Usually there is a hardware swap for this but on mac there doesn't appear to be one. This uses the decoder swap for now until we know the canonical swap call and add a trace there. TBR=nduca@chromium.org NOTRY=true No-try since this is blocking this from working on the mac and I've run the tests locally. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245478

Patch Set 1 : #

Patch Set 2 : Gpu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M tools/perf/metrics/timeline.py View 3 chunks +21 lines, -12 lines 0 comments Download
M tools/perf/metrics/timeline_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
epenner
Ptal. If this doesn't fix the mac I'll likely need to run it locally. From ...
6 years, 11 months ago (2014-01-17 03:12:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/141163004/50001
6 years, 11 months ago (2014-01-17 03:17:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/141163004/90001
6 years, 11 months ago (2014-01-17 04:09:56 UTC) #3
nduca
lgtm should we just use drawLayers on the compositor thread to indicate this? or use ...
6 years, 11 months ago (2014-01-17 04:26:05 UTC) #4
epenner
On 2014/01/17 04:26:05, nduca wrote: > lgtm should we just use drawLayers on the compositor ...
6 years, 11 months ago (2014-01-17 04:34:01 UTC) #5
ernstm
On 2014/01/17 04:34:01, epenner wrote: > On 2014/01/17 04:26:05, nduca wrote: > > lgtm should ...
6 years, 11 months ago (2014-01-17 06:10:21 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 10:10:12 UTC) #7
Message was sent while issue was closed.
Change committed as 245478

Powered by Google App Engine
This is Rietveld 408576698