third_party/WebKit/Source/platform/heap/Visitor.h - Issue 1411603007: [Oilpan] Add use-after-free detector in Member<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Visitor.h

Issue 1411603007: [Oilpan] Add use-after-free detector in Member<> Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduce gcGenerationUnchecked Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/Visitor.h

diff --git a/third_party/WebKit/Source/platform/heap/Visitor.h b/third_party/WebKit/Source/platform/heap/Visitor.h

index 0c6d21c6381b1326320c8304b3e6858b7692dcc1..4e617546b5e5c6b40151aca316a3ca05db158161 100644

--- a/third_party/WebKit/Source/platform/heap/Visitor.h

+++ b/third_party/WebKit/Source/platform/heap/Visitor.h

@@ -140,7 +140,7 @@ public:

template<typename T>

void trace(const Member<T>& t)

{

- mark(t.get());

+ mark(t.unsafeGet());

}

// Fallback method used only when we need to trace raw pointers of T.