third_party/WebKit/Source/core/css/StylePropertySet.cpp - Issue 1411603007: [Oilpan] Add use-after-free detector in Member<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.cpp

Issue 1411603007: [Oilpan] Add use-after-free detector in Member<> Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/StylePropertySet.cpp

diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.cpp b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

index e8d5465910a67063a90db27a7138ee8e45a57e17..62200c2b375ab05ed69fe1f11569e1eacd91c292 100644

--- a/third_party/WebKit/Source/core/css/StylePropertySet.cpp

+++ b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

@@ -42,7 +42,7 @@ namespace blink {

static size_t sizeForImmutableStylePropertySetWithPropertyCount(unsigned count)

{

- return sizeof(ImmutableStylePropertySet) - sizeof(void*) + sizeof(CSSValue*) * count + sizeof(StylePropertyMetadata) * count;

+ return sizeof(ImmutableStylePropertySet) - sizeof(void*) + sizeof(RawPtrWillBeMember<CSSValue>) * count + sizeof(StylePropertyMetadata) * count;

haraken 2015/11/10 16:37:05 Let's land this change separately.

peria 2015/11/11 02:46:34 Done. https://codereview.chromium.org/1433843002/

}

PassRefPtrWillBeRawPtr<ImmutableStylePropertySet> ImmutableStylePropertySet::create(const CSSProperty* properties, unsigned count, CSSParserMode cssParserMode)

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/GarbageCollected.h » ('j') | third_party/WebKit/Source/platform/heap/Handle.h » ('J')