tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py - Issue 1411603005: Add Workman keyboard layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py

Issue 1411603005: Add Workman keyboard layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py

diff --git a/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py b/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py

index 67b5bebd1efa96d2d3ff492c3abfbb6f14803b74..91790ce272342469af9c5109f95babd626d21e1d 100755

--- a/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py

+++ b/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py

@@ -135,7 +135,9 @@ INPUT_METHOD_ID_TO_OVERLAY_ID = {

'xkb:us:dvorak:eng': 'en_US_dvorak',

'xkb:us:intl:eng': 'en_US_intl',

'xkb:us:intl:nld': 'en_US_intl',

- 'xkb:us:intl:por': 'en_US_intl'

+ 'xkb:us:intl:por': 'en_US_intl',

+ 'xkb:us:workman:eng': 'en_US_workman',

+ 'xkb:us:workman-intl:eng': 'en_US_workman_intl'

scottmg 2015/11/20 19:10:59 add trailing ,

Kenny Root (Google) 2015/11/21 00:22:11 Done.

}

# The file was first generated in 2012 and we have a policy of not updating