Add Workman keyboard layout

Add Workman keyboard layout

Adds the Workman keyboard layouts available in modern xkeyboard-config
packages to the Chromium OS builds.

BUG=None
TEST=unit_tests and browser_tests pass, manual testing on device works with new layouts

Committed: https://crrev.com/e92f7d6e57129c737623e8ba4a7d1082fbf1c019
Cr-Commit-Position: refs/heads/master@{#360973}

[Kenny Root, 2015-10-27 20:50:16]

Description was changed from

==========
Add Workman keyboard layout

Adds the Workman keyboard layouts available in modern xkeyboard-config
packages to the Chromium OS builds.

BUG=None
TEST=unit_tests and browser_tests pass
==========

to

==========
Add Workman keyboard layout

Adds the Workman keyboard layouts available in modern xkeyboard-config
packages to the Chromium OS builds.

BUG=None
TEST=unit_tests and browser_tests pass
==========

[Kenny Root, 2015-10-27 20:50:16]

kroot@chromium.org changed reviewers:
+ shuchen@chromium.org

[Kenny Root, 2015-10-27 20:51:54]

kroot@chromium.org changed reviewers:
+ achuith@chromium.org

[Kenny Root (Google), 2015-11-03 21:18:18]

Description was changed from

==========
Add Workman keyboard layout

Adds the Workman keyboard layouts available in modern xkeyboard-config
packages to the Chromium OS builds.

BUG=None
TEST=unit_tests and browser_tests pass
==========

to

==========
Add Workman keyboard layout

Adds the Workman keyboard layouts available in modern xkeyboard-config
packages to the Chromium OS builds.

BUG=None
TEST=unit_tests and browser_tests pass, manual testing on device works with new
layouts
==========

[Shu Chen, 2015-11-04 03:45:12]

https://codereview.chromium.org/1411603005/diff/40001/chromeos/ime/input_meth...
File chromeos/ime/input_methods.txt (right):

https://codereview.chromium.org/1411603005/diff/40001/chromeos/ime/input_meth...
chromeos/ime/input_methods.txt:51: xkb:us:workman:eng    us(workman)    en,en-US
            WK   login
should xkb:us:workman-intl:eng be listed here?

[achuithb, 2015-11-04 18:15:00]

achuith@chromium.org changed reviewers:
+ alemate@chromium.org

[achuithb, 2015-11-04 18:15:01]

Alex, are you the right person to review this?

[Alexander Alekseev, 2015-11-04 18:32:27]

https://codereview.chromium.org/1411603005/diff/40001/chromeos/ime/input_meth...
File chromeos/ime/input_methods.txt (right):

https://codereview.chromium.org/1411603005/diff/40001/chromeos/ime/input_meth...
chromeos/ime/input_methods.txt:29: #    *
tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py
Update this?

[Kenny Root (Google), 2015-11-06 18:46:42]

kroot@google.com changed reviewers:
+ kroot@google.com

[Kenny Root (Google), 2015-11-06 18:46:43]

https://codereview.chromium.org/1411603005/diff/40001/chromeos/ime/input_meth...
File chromeos/ime/input_methods.txt (right):

https://codereview.chromium.org/1411603005/diff/40001/chromeos/ime/input_meth...
chromeos/ime/input_methods.txt:29: #    *
tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py
On 2015/11/04 18:32:27, Alexander Alekseev wrote:
> Update this?

I updated the script, but I can't run the script since I apparently don't have
access to the hotkey spreadsheet.

https://codereview.chromium.org/1411603005/diff/40001/chromeos/ime/input_meth...
chromeos/ime/input_methods.txt:51: xkb:us:workman:eng    us(workman)    en,en-US
            WK   login
On 2015/11/04 03:45:12, Shu Chen wrote:
> should xkb:us:workman-intl:eng be listed here?

Done.

[Kenny Root (Google), 2015-11-17 19:17:43]

Anything else neede here?

[Shu Chen, 2015-11-18 05:02:05]

lgtm

[Alexander Alekseev, 2015-11-18 07:10:36]

lgtm

[Kenny Root (Google), 2015-11-18 08:06:59]

The CQ bit was checked by kroot@google.com

[commit-bot: I haz the power, 2015-11-18 08:07:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411603005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411603005/60001

[commit-bot: I haz the power, 2015-11-18 08:15:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 08:15:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Kenny Root (Google), 2015-11-18 08:25:30]

On 2015/11/18 08:15:52, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

It looks like I still need an approver for
tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py

By the way, I can't access the spreadsheet it refers to and no one has answered
my request to view. It points to 0AqzoqbAMLyEPdE1RQXdodk1qVkFyTWtQbUxROVM1cXc

[Kenny Root (Google), 2015-11-19 21:48:50]

The CQ bit was checked by kroot@google.com

[Kenny Root (Google), 2015-11-19 21:48:50]

lgtm

[commit-bot: I haz the power, 2015-11-19 21:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411603005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411603005/60001

[xiyuan, 2015-11-19 22:09:29]

xiyuan@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2015-11-19 22:09:30]

chrome/browser/resources/chromeos LGTM

[Kenny Root (Google), 2015-11-19 22:11:31]

The CQ bit was unchecked by kroot@google.com

[Kenny Root (Google), 2015-11-19 22:11:41]

The CQ bit was checked by kroot@google.com

[commit-bot: I haz the power, 2015-11-19 22:12:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411603005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411603005/60001

[commit-bot: I haz the power, 2015-11-19 22:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 22:28:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)

[Kenny Root (Google), 2015-11-19 22:29:57]

The CQ bit was checked by kroot@google.com

[commit-bot: I haz the power, 2015-11-19 22:33:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411603005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411603005/60001

[commit-bot: I haz the power, 2015-11-19 23:08:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 23:08:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)

[scottmg, 2015-11-20 19:10:59]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-11-20 19:10:59]

tools/ lgtm

https://codereview.chromium.org/1411603005/diff/60001/tools/gen_keyboard_over...
File tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py (right):

https://codereview.chromium.org/1411603005/diff/60001/tools/gen_keyboard_over...
tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py:140:
'xkb:us:workman-intl:eng': 'en_US_workman_intl'
add trailing ,

[Kenny Root (Google), 2015-11-21 00:22:11]

https://codereview.chromium.org/1411603005/diff/60001/tools/gen_keyboard_over...
File tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py (right):

https://codereview.chromium.org/1411603005/diff/60001/tools/gen_keyboard_over...
tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py:140:
'xkb:us:workman-intl:eng': 'en_US_workman_intl'
On 2015/11/20 19:10:59, scottmg wrote:
> add trailing ,

Done.

[Kenny Root, 2015-11-21 00:23:16]

The CQ bit was checked by kroot@chromium.org

[Kenny Root, 2015-11-21 00:23:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
alemate@chromium.org, xiyuan@chromium.org, scottmg@chromium.org,
shuchen@chromium.org, kroot@google.com
Link to the patchset: https://codereview.chromium.org/1411603005/#ps80001
(title: "Add trailing comma according to review feedback")

[commit-bot: I haz the power, 2015-11-21 00:24:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411603005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411603005/80001

[commit-bot: I haz the power, 2015-11-21 01:07:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-21 01:08:14]

Patchset 5 (id:??) landed as
https://crrev.com/e92f7d6e57129c737623e8ba4a7d1082fbf1c019
Cr-Commit-Position: refs/heads/master@{#360973}