ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h - Issue 1411593004: Eliminate //chrome dependencies from MetricsServicesManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

Issue 1411593004: Eliminate //chrome dependencies from MetricsServicesManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix official build Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/test_metrics_service_client.cc ('k') | ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

diff --git a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h b/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

index bc9842fbc55d103bfad892a534db98eb9dab0368..ff2bad2a865ab14df379f0d0a2ed0e704d3be7e6 100644

--- a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

+++ b/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

@@ -50,6 +50,7 @@ class IOSChromeMetricsServiceClient

static void RegisterPrefs(PrefRegistrySimple* registry);

// metrics::MetricsServiceClient:

+ metrics::MetricsService* GetMetricsService() override;

void SetMetricsClientId(const std::string& client_id) override;

void OnRecordingDisabled() override;

bool IsOffTheRecordSessionActive() override;

@@ -71,8 +72,6 @@ class IOSChromeMetricsServiceClient

void WebStateDidStartLoading(web::WebState* web_state) override;

void WebStateDidStopLoading(web::WebState* web_state) override;

- metrics::MetricsService* metrics_service() { return metrics_service_.get(); }

// Records an unexpected renderer (web) process termination.

// This path only exists on iOS because the other platforms use the (now

// deprecated) content::Notification system to get this information into the