chrome/browser/browser_process_impl.cc - Issue 1411593004: Eliminate //chrome dependencies from MetricsServicesManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 1411593004: Eliminate //chrome dependencies from MetricsServicesManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix official build Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_process_impl.cc

diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc

index 0cf96a73813b5bc2802a82c33b0173ff24b5afed..6f303c74c2934fc5d7c76098632677d738b453c1 100644

--- a/chrome/browser/browser_process_impl.cc

+++ b/chrome/browser/browser_process_impl.cc

@@ -43,6 +43,7 @@

#include "chrome/browser/io_thread.h"

#include "chrome/browser/lifetime/application_lifetime.h"

#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"

+#include "chrome/browser/metrics/chrome_metrics_services_manager_client.h"

#include "chrome/browser/metrics/metrics_services_manager.h"

#include "chrome/browser/metrics/thread_watcher.h"

#include "chrome/browser/net/chrome_net_log_helper.h"

@@ -535,8 +536,10 @@ void BrowserProcessImpl::EndSession() {

MetricsServicesManager* BrowserProcessImpl::GetMetricsServicesManager() {

DCHECK(CalledOnValidThread());

- if (!metrics_services_manager_)

- metrics_services_manager_.reset(new MetricsServicesManager(local_state()));

+ if (!metrics_services_manager_) {

+ metrics_services_manager_.reset(new MetricsServicesManager(make_scoped_ptr(

+ new ChromeMetricsServicesManagerClient(local_state()))));

+ }

return metrics_services_manager_.get();

}

« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_metrics_service_accessor.h » ('j') | no next file with comments »