Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: pdfium.gyp

Issue 1411583005: Turn on chromium_code (except -Wsign-compare, for now) for pdfium (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: sort Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index db1c52774a0108d9361c0667d6cc99eac6c5c0af..878879484811963ba4708633651df2b961377b86 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -1,5 +1,6 @@
{
'variables': {
+ 'chromium_code': 1,
'pdf_use_skia%': 0,
'pdf_enable_v8%': 1,
'conditions': [
@@ -42,6 +43,12 @@
'msvs_disabled_warnings': [
4005, 4018, 4146, 4333, 4345, 4267
],
+ 'variables': {
+ 'clang_warning_flags': [
+ # TODO(thestig): Fix all instances, remove this, pdfium:29
+ '-Wno-sign-compare',
+ ],
+ },
},
'targets': [
{
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698