Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: pdfium.gyp

Issue 1411583005: Turn on chromium_code (except -Wsign-compare, for now) for pdfium (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'chromium_code': 1,
3 'pdf_use_skia%': 0, 4 'pdf_use_skia%': 0,
4 'pdf_enable_v8%': 1, 5 'pdf_enable_v8%': 1,
5 'conditions': [ 6 'conditions': [
6 ['OS=="linux"', { 7 ['OS=="linux"', {
7 'bundle_freetype%': 0, 8 'bundle_freetype%': 0,
8 }, { # On Android there's no system FreeType. On Windows and Mac, only a 9 }, { # On Android there's no system FreeType. On Windows and Mac, only a
9 # few methods are used from it. 10 # few methods are used from it.
10 'bundle_freetype%': 1, 11 'bundle_freetype%': 1,
11 }], 12 }],
12 ], 13 ],
(...skipping 22 matching lines...) Expand all
35 }], 36 }],
36 ['target_arch=="ia32"', { 37 ['target_arch=="ia32"', {
37 'defines' : [ '_FX_CPU_=_FX_X86_', ], 38 'defines' : [ '_FX_CPU_=_FX_X86_', ],
38 }], 39 }],
39 ], 40 ],
40 }], 41 }],
41 ], 42 ],
42 'msvs_disabled_warnings': [ 43 'msvs_disabled_warnings': [
43 4005, 4018, 4146, 4333, 4345, 4267 44 4005, 4018, 4146, 4333, 4345, 4267
44 ], 45 ],
46 'variables': {
47 'clang_warning_flags': [
48 # TODO(thakis): Fix all instances, remove this.
49 '-Wno-sign-compare',
50 ],
51 },
45 }, 52 },
46 'targets': [ 53 'targets': [
47 { 54 {
48 'target_name': 'pdfium', 55 'target_name': 'pdfium',
49 'type': 'static_library', 56 'type': 'static_library',
50 'dependencies': [ 57 'dependencies': [
51 'third_party/third_party.gyp:bigint', 58 'third_party/third_party.gyp:bigint',
52 'third_party/third_party.gyp:pdfium_base', 59 'third_party/third_party.gyp:pdfium_base',
53 'fdrm', 60 'fdrm',
54 'fpdfdoc', 61 'fpdfdoc',
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 ], 802 ],
796 'dependencies': [ 803 'dependencies': [
797 '<(DEPTH)/v8/tools/gyp/v8.gyp:v8', 804 '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
798 '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform', 805 '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform',
799 ], 806 ],
800 }], 807 }],
801 ], 808 ],
802 }, 809 },
803 ], 810 ],
804 } 811 }
OLDNEW
« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698