Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1411573014: Fix race in impl/memory. (Closed)

Created:
5 years, 1 month ago by iannucci
Modified:
5 years, 1 month ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M impl/memory/datastore_data.go View 7 chunks +17 lines, -10 lines 1 comment Download
M impl/memory/gkvlite_utils.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
iannucci
5 years, 1 month ago (2015-11-06 23:23:40 UTC) #1
iannucci
https://chromiumcodereview.appspot.com/1411573014/diff/1/impl/memory/datastore_data.go File impl/memory/datastore_data.go (left): https://chromiumcodereview.appspot.com/1411573014/diff/1/impl/memory/datastore_data.go#oldcode223 impl/memory/datastore_data.go:223: ents := d.mutableEnts(incomplete.Namespace()) apparently getting a collection locked, releasing ...
5 years, 1 month ago (2015-11-06 23:25:03 UTC) #2
Vadim Sh.
lgtm
5 years, 1 month ago (2015-11-06 23:44:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411573014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411573014/1
5 years, 1 month ago (2015-11-06 23:44:34 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 23:47:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/525a1181d6016089e0eafceb704c840c63b23b2e

Powered by Google App Engine
This is Rietveld 408576698