Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: ios/chrome/browser/browser_state/browser_state_info_cache.h

Issue 1411573009: [iOS] Remove BrowserState names in BrowserStateInfoCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/browser_state/browser_state_info_cache.h
diff --git a/ios/chrome/browser/browser_state/browser_state_info_cache.h b/ios/chrome/browser/browser_state/browser_state_info_cache.h
index 53fc47b35ad34cc00b85d753b1ebd3544c3d83bd..2bcd6c8ed8e63c11a0972d255d4bdcb843bb78c3 100644
--- a/ios/chrome/browser/browser_state/browser_state_info_cache.h
+++ b/ios/chrome/browser/browser_state/browser_state_info_cache.h
@@ -30,7 +30,6 @@ class BrowserStateInfoCache {
virtual ~BrowserStateInfoCache();
void AddBrowserState(const base::FilePath& browser_state_path,
- const base::string16& name,
const std::string& gaia_id,
const base::string16& user_name);
void RemoveBrowserState(const base::FilePath& browser_state_path);
@@ -45,7 +44,6 @@ class BrowserStateInfoCache {
// Gets and sets information related to browser states.
size_t GetIndexOfBrowserStateWithPath(
const base::FilePath& browser_state_path) const;
- base::string16 GetNameOfBrowserStateAtIndex(size_t index) const;
base::string16 GetUserNameOfBrowserStateAtIndex(size_t index) const;
base::FilePath GetPathOfBrowserStateAtIndex(size_t index) const;
std::string GetGAIAIdOfBrowserStateAtIndex(size_t index) const;
@@ -69,9 +67,7 @@ class BrowserStateInfoCache {
std::string CacheKeyFromBrowserStatePath(
const base::FilePath& browser_state_path) const;
- std::vector<std::string>::iterator FindPositionForBrowserState(
- const std::string& search_key,
- const base::string16& search_name);
+ void InsertSortedKey(const std::string& key);
PrefService* prefs_;
std::vector<std::string> sorted_keys_;

Powered by Google App Engine
This is Rietveld 408576698