[iOS] Remove BrowserState names in BrowserStateInfoCache

[iOS] Remove BrowserState names in BrowserStateInfoCache

On iOS, BrowserState do not have names. The code to support names can be
removed.

Committed: https://crrev.com/aa1ab978559ed5b637d97955637e7f3b68109804
Cr-Commit-Position: refs/heads/master@{#357090}

[droger, 2015-10-29 14:13:52]

droger@chromium.org changed reviewers:
+ bzanotti@chromium.org

[bzanotti, 2015-10-30 10:49:07]

https://codereview.chromium.org/1411573009/diff/1/ios/chrome/browser/browser_...
File ios/chrome/browser/browser_state/browser_state_info_cache.cc (right):

https://codereview.chromium.org/1411573009/diff/1/ios/chrome/browser/browser_...
ios/chrome/browser/browser_state/browser_state_info_cache.cc:204:
BrowserStateInfoCache::FindPositionForBrowserState(
This function is now literally doing the same thing as this:

return std::upper_bound(sorted_keys_.begin(), sorted_keys_.end(), search_key);

As it is only used to insert the key in sorted_keys_, you could even do this:

void BrowserStateInfoCache::InsertSortedKeyForBrowserState(const std::string&
key) {
  sorted_keys_.insert(std::upper_bound(sorted_keys_.begin(), sorted_keys_.end(),
key), key);
}

[droger, 2015-10-30 11:49:44]

Thanks, done.

[droger, 2015-10-30 11:51:36]

Patchset #2 (id:20001) has been deleted

[bzanotti, 2015-10-30 12:13:50]

LGTM with one nit. Please consider it before CQ'ing.

https://codereview.chromium.org/1411573009/diff/40001/ios/chrome/browser/brow...
File ios/chrome/browser/browser_state/browser_state_info_cache.cc (right):

https://codereview.chromium.org/1411573009/diff/40001/ios/chrome/browser/brow...
ios/chrome/browser/browser_state/browser_state_info_cache.cc:204: void
BrowserStateInfoCache::InsertSortedKey(const std::string& key) {
Nit: Please consider renaming this function to something more clear. Now that I
see the function used in the rest of the code, I don't find the name very
explicit. :/

[droger, 2015-10-30 13:01:51]

https://codereview.chromium.org/1411573009/diff/40001/ios/chrome/browser/brow...
File ios/chrome/browser/browser_state/browser_state_info_cache.cc (right):

https://codereview.chromium.org/1411573009/diff/40001/ios/chrome/browser/brow...
ios/chrome/browser/browser_state/browser_state_info_cache.cc:204: void
BrowserStateInfoCache::InsertSortedKey(const std::string& key) {
On 2015/10/30 12:13:49, bzanotti wrote:
> Nit: Please consider renaming this function to something more clear. Now that
I
> see the function used in the rest of the code, I don't find the name very
> explicit. :/

Renamed to AddBrowserStateCacheKey()

[droger, 2015-10-30 13:20:22]

The CQ bit was checked by droger@chromium.org

[droger, 2015-10-30 13:20:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
bzanotti@chromium.org
Link to the patchset: https://codereview.chromium.org/1411573009/#ps60001
(title: "Rename method")

[commit-bot: I haz the power, 2015-10-30 13:20:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411573009/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411573009/60001

[commit-bot: I haz the power, 2015-10-30 13:24:47]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-10-30 13:25:24]

Patchset 3 (id:??) landed as
https://crrev.com/aa1ab978559ed5b637d97955637e7f3b68109804
Cr-Commit-Position: refs/heads/master@{#357090}