Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1411573002: Handle Mozilla license blocks in the GN header checker. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle Mozilla license blocks in the GN header checker. The include iterator doesn't handle real C preprocessor. Mozilla license blocks use C-style comments with *'s along the left, and are long enough that the header checker gives up. This patch doesn't fix the general comment issue, different types of comments can still confuse us, but Mozilla license blocks in particular are now handled. BUG=543850 Committed: https://crrev.com/a2d721a90e955ee4fad4584c150e4aaca42e94d7 Cr-Commit-Position: refs/heads/master@{#354454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M tools/gn/c_include_iterator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/c_include_iterator_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 2 months ago (2015-10-15 22:17:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411573002/1
5 years, 2 months ago (2015-10-15 22:18:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 22:35:00 UTC) #6
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-16 01:17:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411573002/1
5 years, 2 months ago (2015-10-16 05:29:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 05:34:34 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 05:35:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2d721a90e955ee4fad4584c150e4aaca42e94d7
Cr-Commit-Position: refs/heads/master@{#354454}

Powered by Google App Engine
This is Rietveld 408576698