prune unused SkNx features

prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.  This will help keep the complexity down.

This may cause minor diffs in radial gradients: toBytes() rounds where castTrunc() truncated.  But I don't see any diffs in Gold.
https://gold.skia.org/search2?issue=1411563008&unt=true&query=source_type%3Dgm&master=false

BUG=skia:4117
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/6f797092d2054f79374fb98fc1d57ca3554c7db4

[mtklein_C, 2015-11-09 15:42:14]

Description was changed from

==========
prune unused SkNx features

  - remove float -> int conversion, keepign float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
prune unused SkNx features

  - remove float -> int conversion, keepign float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients:
toBytes() rounds where castTrunc() truncated.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2015-11-09 15:44:23]

Description was changed from

==========
prune unused SkNx features

  - remove float -> int conversion, keepign float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients:
toBytes() rounds where castTrunc() truncated.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
prune unused SkNx features

  - remove float -> int conversion, keepign float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients:
toBytes() rounds where castTrunc() truncated.
The caches these index are 8-bit, so it fits perfectly.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2015-11-09 15:44:28]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 15:44:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411563008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411563008/1

[commit-bot: I haz the power, 2015-11-09 15:46:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 15:46:47]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein_C, 2015-11-09 15:49:16]

Description was changed from

==========
prune unused SkNx features

  - remove float -> int conversion, keepign float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients:
toBytes() rounds where castTrunc() truncated.
The caches these index are 8-bit, so it fits perfectly.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients:
toBytes() rounds where castTrunc() truncated.
The caches these index are 8-bit, so it fits perfectly.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2015-11-09 15:49:22]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 15:49:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411563008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411563008/20001

[commit-bot: I haz the power, 2015-11-09 15:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 15:51:26]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein, 2015-11-09 16:08:09]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 16:08:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411563008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411563008/40001

[mtklein, 2015-11-09 16:08:48]

Description was changed from

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients:
toBytes() rounds where castTrunc() truncated.
The caches these index are 8-bit, so it fits perfectly.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients: toBytes() rounds where
castTrunc() truncated.  But I don't see any diffs in Gold.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein, 2015-11-09 16:09:18]

Description was changed from

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients: toBytes() rounds where
castTrunc() truncated.  But I don't see any diffs in Gold.

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients: toBytes() rounds where
castTrunc() truncated.  But I don't see any diffs in Gold.
https://gold.skia.org/search2?issue=1411563008&unt=true&query=source_type%3Dg...

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein, 2015-11-09 16:09:37]

Description was changed from

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.
This will help keep the complexity down.

This may cause minor diffs in radial gradients: toBytes() rounds where
castTrunc() truncated.  But I don't see any diffs in Gold.
https://gold.skia.org/search2?issue=1411563008&unt=true&query=source_type%3Dg...

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.  This will help keep the complexity
down.

This may cause minor diffs in radial gradients: toBytes() rounds where
castTrunc() truncated.  But I don't see any diffs in Gold.
https://gold.skia.org/search2?issue=1411563008&unt=true&query=source_type%3Dg...

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2015-11-09 16:12:26]

mtklein@chromium.org changed reviewers:
+ reed@google.com
- mtklein@google.com

[mtklein_C, 2015-11-09 16:12:27]

Pretty much just code deletion.

[commit-bot: I haz the power, 2015-11-09 16:18:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 16:18:56]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-11-09 16:27:15]

Description was changed from

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.  This will help keep the complexity
down.

This may cause minor diffs in radial gradients: toBytes() rounds where
castTrunc() truncated.  But I don't see any diffs in Gold.
https://gold.skia.org/search2?issue=1411563008&unt=true&query=source_type%3Dg...

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
prune unused SkNx features

  - remove float -> int conversion, keeping float -> byte
  - remove support for doubles

I was thinking of specializing Sk8f for AVX.  This will help keep the complexity
down.

This may cause minor diffs in radial gradients: toBytes() rounds where
castTrunc() truncated.  But I don't see any diffs in Gold.
https://gold.skia.org/search2?issue=1411563008&unt=true&query=source_type%3Dg...

BUG=skia:4117
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[reed1, 2015-11-09 16:28:50]

... always a good change :)
lgtm

[mtklein, 2015-11-09 16:33:02]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-11-09 16:33:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411563008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411563008/40001

[commit-bot: I haz the power, 2015-11-09 16:33:57]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6f797092d2054f79374fb98fc1d57ca3554c7db4

[mtklein_C, 2015-11-09 19:23:05]

Just correcting myself for posterity:

Converting the radial gradient code from castTrunc() to toBytes() was bit
perfect:
toBytes() truncates too.