Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1411553010: Merge to XFA: One test runner to rule them all. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: One test runner to rule them all. This CL takes the three test runners (corpus, javascript, pixel) and combines the code into a single test_runner file. Each of the individual runners still exists and calls the test runner with their data directory. With this change, the pixel and javascript test will now run in parallel if multiple processors are available. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1430623006 . (cherry picked from commit a1215ba51a235fb7abcb995f0e768ea0176d9275) Committed: https://pdfium.googlesource.com/pdfium/+/a2d64303a3562d1c81817121b57cdd265e1a76d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -315 lines) Patch
M testing/tools/run_corpus_tests.py View 1 chunk +3 lines, -155 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 chunk +3 lines, -74 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +3 lines, -86 lines 0 comments Download
A testing/tools/test_runner.py View 1 chunk +229 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
TBRing, merge clean.
5 years, 1 month ago (2015-11-03 15:15:22 UTC) #1
dsinclair
Committed patchset #1 (id:1) manually as a2d64303a3562d1c81817121b57cdd265e1a76d0 (presubmit successful).
5 years, 1 month ago (2015-11-03 15:15:30 UTC) #2
Lei Zhang
5 years, 1 month ago (2015-11-03 15:20:16 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698