Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1411553005: mac: Let remoting_host_prefpane link with libc++. (Closed)

Created:
5 years, 2 months ago by Nico
Modified:
5 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Let remoting_host_prefpane link with libc++. Once I figured out the static library libc++ build story, I'll likely move this target back to libstdc++, but for now it works with libc++, so use the libc++ in component build like every other target does. See comment 7 on the linked bug for why the file in overrides/ is needed. BUG=544531 Committed: https://crrev.com/bed1d0c35e86bc859f94573b4c15d18c17994383 Cr-Commit-Position: refs/heads/master@{#354824}

Patch Set 1 #

Patch Set 2 : readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M remoting/remoting_host_mac.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M third_party/jsoncpp/README.chromium View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 2 months ago (2015-10-18 04:56:30 UTC) #2
Lambros
lgtm
5 years, 2 months ago (2015-10-19 17:47:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411553005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411553005/20001
5 years, 2 months ago (2015-10-19 18:14:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-19 19:32:20 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 19:33:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bed1d0c35e86bc859f94573b4c15d18c17994383
Cr-Commit-Position: refs/heads/master@{#354824}

Powered by Google App Engine
This is Rietveld 408576698