Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411553004: Add autoroll server (Closed)

Created:
5 years, 2 months ago by borenet
Modified:
5 years, 2 months ago
Reviewers:
jcgregorio, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@arb_status
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : WIP #

Patch Set 2 : Fixes #

Patch Set 3 : More fixes #

Total comments: 2

Patch Set 4 : Add error-toast-sk to app-sk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -47 lines) Patch
A + autoroll/.bowerrc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + autoroll/Makefile View 1 chunk +4 lines, -7 lines 0 comments Download
A + autoroll/README.md View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + autoroll/bower.json View 1 chunk +2 lines, -2 lines 0 comments Download
A autoroll/build_release View 1 chunk +21 lines, -0 lines 0 comments Download
A + autoroll/elements.html View 2 3 2 chunks +2 lines, -5 lines 0 comments Download
A autoroll/go/autoroll/main.go View 1 2 1 chunk +232 lines, -0 lines 0 comments Download
A + autoroll/package.json View 1 chunk +2 lines, -2 lines 0 comments Download
M autoroll/res/imp/arb-status-sk.html View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + autoroll/sys/autorolld.service View 1 1 chunk +6 lines, -7 lines 0 comments Download
A + autoroll/templates/header.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + autoroll/templates/main.html View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M res/imp/9/app-sk.html View 1 2 3 5 chunks +47 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
borenet
Screenshot: https://screenshot.googleplex.com/DCEi4tA1Tq6.png
5 years, 2 months ago (2015-10-20 13:38:53 UTC) #2
jcgregorio
lgtm https://codereview.chromium.org/1411553004/diff/40001/autoroll/templates/main.html File autoroll/templates/main.html (right): https://codereview.chromium.org/1411553004/diff/40001/autoroll/templates/main.html#newcode29 autoroll/templates/main.html:29: <error-toast-sk></error-toast-sk> Why not put error-toast-sk in app-sk?
5 years, 2 months ago (2015-10-20 13:56:07 UTC) #3
borenet
https://codereview.chromium.org/1411553004/diff/40001/autoroll/templates/main.html File autoroll/templates/main.html (right): https://codereview.chromium.org/1411553004/diff/40001/autoroll/templates/main.html#newcode29 autoroll/templates/main.html:29: <error-toast-sk></error-toast-sk> On 2015/10/20 13:56:07, jcgregorio wrote: > Why not ...
5 years, 2 months ago (2015-10-20 14:00:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411553004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411553004/60001
5 years, 2 months ago (2015-10-20 14:42:22 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 14:43:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/buildbot/+/3e8cd1abd9de0662ee53175b9c54d57803de...

Powered by Google App Engine
This is Rietveld 408576698