PRESUBMIT: Bark about DISALLOW_* macros without #include "base/macros.h"

PRESUBMIT_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import glob
 import json
 import os
 import re
 import subprocess
@@ skipping 395 matching lines @@
 
   def testSingletonInCC(self):
     diff_cc = ['Foo* foo = base::Singleton<Foo>::get();']
     mock_input_api = MockInputApi()
     mock_input_api.files = [MockAffectedFile('some/path/foo.cc', diff_cc)]
     warnings = PRESUBMIT._CheckSingletonInHeaders(mock_input_api,
                                                   MockOutputApi())
     self.assertEqual(0, len(warnings))
 
 
+class CheckBaseMacrosInHeadersTest(unittest.TestCase):
+  def _make_h(self, macro, header):
+    return ("""
+#include "base/%s.h"
+
+class Thing {
+ private:
+  DISALLOW_%s(Thing);
+};
+""" % (macro, header)).splitlines()
+
+  def testBaseMacrosInHeadersBad(self):
+    mock_input_api = MockInputApi()
+    mock_input_api.files = [
+      MockAffectedFile('foo.h', self._make_h('not_macros', 'ASSIGN')),
+      MockAffectedFile('bar.h', self._make_h('not_macros', 'COPY')),
+      MockAffectedFile('baz.h', self._make_h('not_macros', 'COPY_AND_ASSIGN')),
+      MockAffectedFile('qux.h', self._make_h('not_macros', 'EVIL')),
+    ]
+    warnings = PRESUBMIT._CheckBaseMacrosInHeaders(mock_input_api,
+                                                   MockOutputApi())
+    self.assertEqual(1, len(warnings))
+    self.assertEqual(4, len(warnings[0].items))
+
+  def testBaseMacrosInHeadersGood(self):
+    mock_input_api = MockInputApi()
+    mock_input_api.files = [
+      MockAffectedFile('foo.h', self._make_h('macros', 'ASSIGN')),
+      MockAffectedFile('bar.h', self._make_h('macros', 'COPY')),
+      MockAffectedFile('baz.h', self._make_h('macros', 'COPY_AND_ASSIGN')),
+      MockAffectedFile('qux.h', self._make_h('macros', 'EVIL')),
+    ]
+    warnings = PRESUBMIT._CheckBaseMacrosInHeaders(mock_input_api,
+                                                   MockOutputApi())
+    self.assertEqual(0, len(warnings))
+
+
 class InvalidOSMacroNamesTest(unittest.TestCase):
   def testInvalidOSMacroNames(self):
     lines = ['#if defined(OS_WINDOWS)',
              ' #elif defined(OS_WINDOW)',
              ' # if defined(OS_MACOSX) || defined(OS_CHROME)',
              '# else  // defined(OS_MAC)',
              '#endif  // defined(OS_MACOS)']
     errors = PRESUBMIT._CheckForInvalidOSMacrosInFile(
         MockInputApi(), MockFile('some/path/foo_platform.cc', lines))
     self.assertEqual(len(lines), len(errors))
@@ skipping 514 matching lines @@
     # Tag must not contain
     nb = len(msgs[4].items)
     self.assertEqual(2, nb,
                      'Expected %d items, found %d: %s' % (2, nb, msgs[4].items))
     self.assertTrue('HasDottedTag.java' in msgs[4].items)
     self.assertTrue('HasOldTag.java' in msgs[4].items)
 
 
 if __name__ == '__main__':
   unittest.main()