Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1915)

Unified Diff: components/omnibox/browser/search_provider.h

Issue 1411543011: Omnibox: Make Keyword Provide More Generous with Matching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: almost all of peter's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/search_provider.h
diff --git a/components/omnibox/browser/search_provider.h b/components/omnibox/browser/search_provider.h
index 26806309a0e0347cd35d542646d239bb403b5d57..4a7191b792f157f785cb2d93cb82f094953f890b 100644
--- a/components/omnibox/browser/search_provider.h
+++ b/components/omnibox/browser/search_provider.h
@@ -66,6 +66,13 @@ class SearchProvider : public BaseSearchProvider,
// match for Autocomplete and registers the contained answer data, if any.
void RegisterDisplayedAnswers(const AutocompleteResult& result);
+ // Calculates the relevance score for the keyword verbatim result (if the
+ // input matches one of the profile's keyword).
Peter Kasting 2015/11/12 20:36:10 Nit: keyword -> keywords
Mark P 2015/11/12 21:42:48 Done.
+ static int CalculateRelevanceForKeywordVerbatim(
+ metrics::OmniboxInputType::Type type,
+ bool allow_exact_keyword_match,
Peter Kasting 2015/11/12 20:36:10 Nit: Add comments about what this arg means.
Mark P 2015/11/12 21:42:48 Done.
+ bool prefer_keyword);
+
// AutocompleteProvider:
void ResetSession() override;
@@ -142,12 +149,6 @@ class SearchProvider : public BaseSearchProvider,
typedef std::vector<history::KeywordSearchTermVisit> HistoryResults;
- // Calculates the relevance score for the keyword verbatim result (if the
- // input matches one of the profile's keyword).
- static int CalculateRelevanceForKeywordVerbatim(
- metrics::OmniboxInputType::Type type,
- bool prefer_keyword);
-
// A helper function for UpdateAllOldResults().
static void UpdateOldResults(bool minimal_changes,
SearchSuggestionParser::Results* results);

Powered by Google App Engine
This is Rietveld 408576698