Omnibox: Make Keyword Provide More Generous with Matching

components/omnibox/browser/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 302 matching lines @@
   // bundled omnibox field trial.
 
   // Returns true if HistoryURL provider should prohibit the URL-what-you-
   // typed match from being the legal default match for non-URL inputs.
   // If this behavior is active, some code in AutocompleteInput::Parse() also
   // gets disabled; this code is unnecessary given the not-allowed-to-be-
   // default constraint.  Returns false if the experiment isn't active.
   static bool PreventUWYTDefaultForNonURLInputs();
 
   // ---------------------------------------------------------
+  // For the aggressive keyword matching experiment that's part of the bundled
+  // omnibox field trial.
+
+  // Return true if KeywordProvider (via TemplateURLService), for auto-

[Peter Kasting, 2015/11/09 23:11:14]

Nit: Return -> Returns

[Mark P, 2015/11/11 07:41:00]

Done.

+  // generated keywords, should consider the registry (e.g., co.uk) an
+  // important part of the keyword name for matching purposes.  Returns true

[Peter Kasting, 2015/11/09 23:11:15]

Nit: Awkward, how about:

Returns whether the KeywordProvider should require users to type any effective
TLD portion ("co.uk") of autogenerated keywords to match against them.

Then name the function KeywordRequiresTld().

[Mark P, 2015/11/11 07:41:00]

This isn't correct.  It can match against them even if this is false.  It's more
about scoring and whether this is considered meaningful.  Revises somewhat
anyway.
I'm sticking with registry for consistency with the underlying net functions.

+  // if the experiment isn't active.
+  static bool KeywordRequiresRegistry();
+
+  // Return true if KeywordProvider (via TemplateURLService), for auto-

[Peter Kasting, 2015/11/09 23:11:14]

Nit: Return -> Returns

[Mark P, 2015/11/11 07:41:00]

Done.

+  // generated keywords, should return a keyword if the user starts typing
+  // the domain name portion, skipping any host before the domain name.
+  // In other words, returns whether the prefix before the domain name should
+  // be considered important for matching purposes.  Returns true if the

[Peter Kasting, 2015/11/09 23:11:14]

Nit: Awkward, how about:

For autogenerated keywords containing more than just a TLD+1, returns whether
the KeywordProvider should require users to type the full hostname to match
against them, rather than just the TLD+1 portion.

Then name the function KeywordRequiresFullHostname().

[Mark P, 2015/11/11 07:41:00]

Revised somewhat in the direction you suggested.
That's not true.  Prefixes are okay.  Instead revised to 
KeywordRequiresPrefixMatch.

+  // experiment isn't active.
+  static bool KeywordRequiresPrefixBeforeDomain();
+
+  // For the relevance score that KeywordProvider should assign to keywords

[Peter Kasting, 2015/11/09 23:11:15]

Nit: For -> Returns

[Mark P, 2015/11/11 07:41:00]

Done.

+  // with nearly-complete matches, i.e., the user has typed all of the
+  // important part of the keyword.  Returns -1 if the experiment isn't active.
+  static int KeywordScoreForNearlyCompleteMatch();
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kDisableProvidersRule[];
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
   static const char kHQPAllowMatchInTLDRule[];
   static const char kHQPAllowMatchInSchemeRule[];
   static const char kZeroSuggestRule[];
   static const char kZeroSuggestVariantRule[];
   static const char kSuggestVariantRule[];
   static const char kDisableResultsCachingRule[];
   static const char kMeasureSuggestPollingDelayFromLastKeystrokeRule[];
   static const char kSuggestPollingDelayMsRule[];
   static const char kHQPFixFrequencyScoringBugsRule[];
   static const char kHQPNumTitleWordsRule[];
   static const char kHQPAlsoDoHUPLikeScoringRule[];
   static const char kPreventUWYTDefaultForNonURLInputsRule[];
+  static const char kKeywordRequiresRegistryRule[];
+  static const char kKeywordRequiresPrefixBeforeDomainRule[];
+  static const char kKeywordScoreForNearlyCompleteMatchRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringTypedCountUseDecayFactorParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
@@ skipping 28 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_