Issue 1411543006: Tweak create_archive.py to output the data as const char instead of const uint8_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411543006: Tweak create_archive.py to output the data as const char instead of const uint8_t (Closed)

Created:
5 years, 1 month ago by Cutch

Modified:
5 years, 1 month ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Tweak create_archive.py to output the data as const char instead of const uint8_t BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/25906f2144335f6c5b637dedde66a67df0a507b2

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	runtime/tools/create_archive.py	View		2 chunks	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 25906f2144335f6c5b637dedde66a67df0a507b2 (presubmit successful).

5 years, 1 month ago (2015-10-27 20:22:57 UTC) #3

Ivan Posva

5 years, 1 month ago (2015-10-28 20:14:51 UTC) #5

Message was sent while issue was closed.

-Ivan

https://codereview.chromium.org/1411543006/diff/1/runtime/tools/create_archiv...
File runtime/tools/create_archive.py (right):

https://codereview.chromium.org/1411543006/diff/1/runtime/tools/create_archiv...
runtime/tools/create_archive.py:59: cc_text += 'static const char %s_[] = {\n  
' % name
As discussed let's change this back to uint8_t but then not try to create hex
numbers.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages