Adds OnClickCanceled callback to views::Button

ui/views/controls/button/custom_button_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/custom_button.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/layout.h"
 #include "ui/events/event_utils.h"
 #include "ui/gfx/screen.h"
@@ skipping 21 matching lines @@
   explicit TestCustomButton()
       : CustomButton(this) {
   }
 
   ~TestCustomButton() override {}
 
   void ButtonPressed(Button* sender, const ui::Event& event) override {
     notified_ = true;
   }
 
+  void OnClickCanceled(const ui::Event& event) override {
+    notified_no_click_ = true;
+  }
+
   bool notified() { return notified_; }
+  bool notified_no_click() { return notified_no_click_; }
 
-  void Reset() { notified_ = false; }
+  void Reset() {
+    notified_ = false;
+    notified_no_click_ = false;
+  }
 
   // CustomButton methods:
   bool IsChildWidget() const override { return is_child_widget_; }
   bool FocusInChildWidget() const override { return focus_in_child_widget_; }
 
   void set_child_widget(bool b) { is_child_widget_ = b; }
   void set_focus_in_child_widget(bool b) { focus_in_child_widget_ = b; }
 
  private:
   bool notified_ = false;
+  bool notified_no_click_ = false;

[Peter Kasting, 2015/12/01 02:03:18]

Why not call these |pressed_| and |canceled_|?  Those seem like clearer and more
direct names.

[varkha, 2015/12/01 19:23:29]

Done.

   bool is_child_widget_ = false;
   bool focus_in_child_widget_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(TestCustomButton);
 };
 
 class TestWidget : public Widget {
  public:
   TestWidget() : Widget() {}
 
@@ skipping 183 matching lines @@
   EXPECT_TRUE(button()->notified());
   button()->Reset();
   // Not a child, but active.
   button()->set_child_widget(false);
   button()->set_focus_in_child_widget(true);
   widget()->set_active(true);
   button()->AcceleratorPressed(ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE));
   EXPECT_TRUE(button()->notified());
 }
 
+// Tests that OnClickCanceled gets called when NotifyClick is not expected
+// anymore.
+TEST_F(CustomButtonTest, NotifyActionNoClick) {
+  gfx::Point center(10, 10);
+
+  // By default the button should notify its listener on mouse release.
+  button()->OnMousePressed(ui::MouseEvent(
+      ui::ET_MOUSE_PRESSED, center, center, ui::EventTimeForNow(),
+      ui::EF_RIGHT_MOUSE_BUTTON, ui::EF_RIGHT_MOUSE_BUTTON));
+  EXPECT_FALSE(button()->notified_no_click());
+
+  button()->OnMouseReleased(ui::MouseEvent(
+      ui::ET_MOUSE_RELEASED, center, center, ui::EventTimeForNow(),
+      ui::EF_RIGHT_MOUSE_BUTTON, ui::EF_RIGHT_MOUSE_BUTTON));
+  EXPECT_TRUE(button()->notified_no_click());
+
+  // Set the notify action to its listener on mouse press.
+  button()->Reset();
+  button()->set_notify_action(CustomButton::NOTIFY_ON_PRESS);
+  button()->OnMousePressed(ui::MouseEvent(
+      ui::ET_MOUSE_PRESSED, center, center, ui::EventTimeForNow(),
+      ui::EF_RIGHT_MOUSE_BUTTON, ui::EF_RIGHT_MOUSE_BUTTON));
+  EXPECT_TRUE(button()->notified_no_click());
+
+  // The button should no longer notify on mouse release.
+  button()->Reset();
+  button()->OnMouseReleased(ui::MouseEvent(
+      ui::ET_MOUSE_RELEASED, center, center, ui::EventTimeForNow(),
+      ui::EF_RIGHT_MOUSE_BUTTON, ui::EF_RIGHT_MOUSE_BUTTON));
+  EXPECT_FALSE(button()->notified_no_click());
+}
+
 // No touch on desktop Mac. Tracked in http://crbug.com/445520.
 #if !defined(OS_MACOSX) || defined(USE_AURA)
 
 namespace {
 
 void PerformGesture(CustomButton* button, ui::EventType event_type) {
   ui::GestureEventDetails gesture_details(event_type);
   base::TimeDelta time_stamp = base::TimeDelta::FromMicroseconds(0);
   ui::GestureEvent gesture_event(0, 0, 0, time_stamp, gesture_details);
   button->OnGestureEvent(&gesture_event);
@@ skipping 43 matching lines @@
   EXPECT_FALSE(CustomButton::AsCustomButton(&label));
 
   Link link(text);
   EXPECT_FALSE(CustomButton::AsCustomButton(&link));
 
   Textfield textfield;
   EXPECT_FALSE(CustomButton::AsCustomButton(&textfield));
 }
 
 }  // namespace views