Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1411513005: [serializer] Move clearing of optimized code map out of GC. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] Move clearing of optimized code map out of GC. This avoids the need to clear optimized code maps within the GC by just preventing entries being added in the first place, whenever a snapshot is being constructed. The main goal here is to simplify the logic in the already complex visitor for our shared function info objects. R=yangguo@chromium.org Committed: https://crrev.com/cd7c416da41d944cfa113b657d15547e78d5a877 Cr-Commit-Position: refs/heads/master@{#31852}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/heap/objects-visiting-inl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-05 18:07:08 UTC) #1
Yang
lgtm
5 years, 1 month ago (2015-11-05 18:44:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411513005/1
5 years, 1 month ago (2015-11-05 19:39:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7494)
5 years, 1 month ago (2015-11-05 19:41:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411513005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411513005/20001
5 years, 1 month ago (2015-11-06 08:48:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 08:56:12 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 08:56:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd7c416da41d944cfa113b657d15547e78d5a877
Cr-Commit-Position: refs/heads/master@{#31852}

Powered by Google App Engine
This is Rietveld 408576698