Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: mojo/devtools/common/devtoolslib/shell.py

Issue 1411503011: devtools: drop Shell.serve_local_directory(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/devtools/common/devtoolslib/shell.py
diff --git a/mojo/devtools/common/devtoolslib/shell.py b/mojo/devtools/common/devtoolslib/shell.py
index b7f39d85d7b065d56fa305c18d234c02b56bdc5b..7e1d395cf6f7ffaba83ad4a928c14ef05f5438e8 100644
--- a/mojo/devtools/common/devtoolslib/shell.py
+++ b/mojo/devtools/common/devtoolslib/shell.py
@@ -6,27 +6,6 @@
class Shell(object):
"""Represents an abstract Mojo shell."""
- def serve_local_directory(self, local_dir_path, port=0, free_host_port=False):
- """Serves the content of the local (host) directory, making it available to
- the shell under the url returned by the function.
-
- The server will run on a separate thread until the program terminates. The
- call returns immediately.
-
- Args:
- local_dir_path: path to the directory to be served
- port: port at which the server will be available to the shell. On Android
- this can be different from the port on which the server runs on the
- host.
- free_host_port: spawn the server a system allocated port. This is ignored
- on Linux, where |port| indicates the port on which the server will be
- spawned.
-
- Returns:
- The url that the shell can use to access the content of |local_dir_path|.
- """
- raise NotImplementedError()
-
def serve_local_directories(self, mappings, port=0, free_host_port=False):
"""Serves the content of the local (host) directories, making it available
to the shell under the url returned by the function.
« no previous file with comments | « mojo/devtools/common/devtoolslib/linux_shell.py ('k') | mojo/devtools/common/devtoolslib/shell_arguments.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698