Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1411503005: Aura on Android: content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_select_file
Patch Set: Addressing some feedback. Fixes for content/child and content/public/browser targets. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e01a4d5484380c82981615cd9ccd33e2f8c18092..33ff01797eed7ac9a3a9026c064bd7636964d295 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -121,10 +121,12 @@
#if defined(OS_ANDROID)
#include "content/browser/android/content_video_view.h"
-#include "content/browser/android/date_time_chooser_android.h"
#include "content/browser/media/android/media_session.h"
+#if !defined(USE_AURA)
no sievers 2015/11/02 22:27:15 nit: for headers should we make the correct style
mfomitchev 2015/11/03 22:23:19 Done.
+#include "content/browser/android/date_time_chooser_android.h"
#include "content/browser/web_contents/web_contents_android.h"
-#endif
+#endif // !USE_AURA
+#endif // OS_ANDROID
#if defined(OS_MACOSX)
#include "base/mac/foundation_util.h"
@@ -668,7 +670,7 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
OnHideValidationMessage)
IPC_MESSAGE_HANDLER(ViewHostMsg_MoveValidationMessage,
OnMoveValidationMessage)
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
IPC_MESSAGE_HANDLER(ViewHostMsg_FindMatchRects_Reply,
OnFindMatchRectsReply)
IPC_MESSAGE_HANDLER(ViewHostMsg_OpenDateTimeDialog,
@@ -1411,7 +1413,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
manifest_manager_host_.reset(new ManifestManagerHost(this));
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
date_time_chooser_.reset(new DateTimeChooserAndroid());
#endif
@@ -3207,7 +3209,7 @@ void WebContentsImpl::OnFindReply(int request_id,
}
}
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
void WebContentsImpl::OnFindMatchRectsReply(
int version,
const std::vector<gfx::RectF>& rects,
@@ -3370,8 +3372,9 @@ void WebContentsImpl::CreateVideoPowerSaveBlocker() {
video_power_save_blocker_ = PowerSaveBlocker::Create(
PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep,
PowerSaveBlocker::kReasonVideoPlayback, "Playing video");
-#if defined(OS_ANDROID)
- static_cast<PowerSaveBlockerImpl*>(video_power_save_blocker_.get())
+ //TODO(mfomitchev): Support PowerSaveBlocker on Aura - crbug.com/546718.
+#if defined(OS_ANDROID) && !defined(USE_AURA)
+static_cast<PowerSaveBlockerImpl*>(video_power_save_blocker_.get())
->InitDisplaySleepBlocker(this);
#endif
}
@@ -4461,7 +4464,7 @@ bool WebContentsImpl::CreateRenderFrameForRenderManager(
return true;
}
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
base::android::ScopedJavaLocalRef<jobject>
WebContentsImpl::GetJavaWebContents() {

Powered by Google App Engine
This is Rietveld 408576698