content/browser/background_sync/background_sync_manager.cc - Issue 1411503005: Aura on Android: content/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.cc

Issue 1411503005: Aura on Android: content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_select_file

Patch Set: Addressing final comments, Mac GN build fix. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/accessibility_tree_formatter.cc ('K') | « content/browser/android/content_video_view.cc ('k') | content/browser/browser_main_loop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.cc

diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc

index 5624239b68c88c40005c2a2c854b89cbda4b3fc9..beb325a44e841c43fb6889b54aab4ce5bb1bc269 100644

--- a/content/browser/background_sync/background_sync_manager.cc

+++ b/content/browser/background_sync/background_sync_manager.cc

@@ -973,7 +973,9 @@ bool BackgroundSyncManager::IsRegistrationReadyToFire(

}

void BackgroundSyncManager::SchedulePendingRegistrations() {

-#if defined(OS_ANDROID)

+// TODO(mfomitchev): Sync play services integration on Android Aura

+// crbug.com/551587.

+#if defined(OS_ANDROID) && !defined(USE_AURA)

bool keep_browser_alive_for_one_shot = false;

for (const auto& sw_id_and_registrations : active_registrations_) {