content/child/BUILD.gn - Issue 1411503005: Aura on Android: content/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/BUILD.gn

Issue 1411503005: Aura on Android: content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_select_file

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/android/java/src/org/chromium/content/browser/BackgroundSyncLauncherService.java » ('j') | content/public/android/java/src/org/chromium/content/browser/BackgroundSyncLauncherService.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/BUILD.gn

diff --git a/content/child/BUILD.gn b/content/child/BUILD.gn

index 0d13f5d99ff675e20aa04ab3a76dc9e88ba27a48..408ea6aacb6476f2179615d04b297337c50f7219 100644

--- a/content/child/BUILD.gn

+++ b/content/child/BUILD.gn

@@ -132,7 +132,7 @@ source_set("child") {

sources -= [ "npapi/webplugin_delegate_impl_mac.mm" ]

}

- if (is_win || !use_aura) {

+ if (enable_plugins && (is_win || is_android || !use_aura)) {

sources -= [ "npapi/webplugin_delegate_impl_aura.cc" ]

no sievers 2015/10/22 20:55:41 do you need the 'enable_plugins' check? it looks a

mfomitchev 2015/11/02 21:51:16 It was needed because it was already being exclude

}