Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1411503005: Aura on Android: content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_select_file
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index dc03b79d8128b232ecf9a6bcd5b18f6e775f1ee0..c8100f447a18a903fbf44fcdf971e55dc5da48dc 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -938,7 +938,7 @@ void RenderProcessHostImpl::CreateMessageFilters() {
AddFilter(new MemoryMessageFilter());
AddFilter(new PushMessagingMessageFilter(
GetID(), storage_partition_impl_->GetServiceWorkerContext()));
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
no sievers 2015/10/22 20:55:41 TODO(crbug.com/546719)
mfomitchev 2015/11/02 21:51:16 Done.
AddFilter(new ScreenOrientationMessageFilterAndroid());
#endif
AddFilter(new GeofencingDispatcherHost(
@@ -971,7 +971,8 @@ void RenderProcessHostImpl::RegisterMojoServices() {
make_scoped_refptr(storage_partition_impl_->GetNavigatorConnectContext()),
message_port_message_filter_));
-#if defined(OS_ANDROID)
+ // TODO(mfomitchev): Hopefully this is not needed...
+#if defined(OS_ANDROID) && !defined(USE_AURA)
ServiceRegistrarAndroid::RegisterProcessHostServices(
no sievers 2015/10/22 20:55:41 revert
mfomitchev 2015/11/02 21:51:16 Done.
mojo_application_host_->service_registry_android());
#endif
@@ -1463,7 +1464,7 @@ bool RenderProcessHostImpl::Shutdown(int exit_code, bool wait) {
if (run_renderer_in_process())
return false; // Single process mode never shuts down the renderer.
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
no sievers 2015/10/22 20:55:41 revert
mfomitchev 2015/11/02 21:51:16 Done.
// Android requires a different approach for killing.
StopChildProcess(GetHandle());
return true;

Powered by Google App Engine
This is Rietveld 408576698