Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411503002: pkg/js: improved readme, added example (Closed)

Created:
5 years, 2 months ago by kevmoo
Modified:
5 years, 2 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -55 lines) Patch
M pkg/js/README.md View 1 2 chunks +83 lines, -4 lines 0 comments Download
A pkg/js/example/chart.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A pkg/js/example/chart_js_example.dart View 1 chunk +67 lines, -0 lines 0 comments Download
A pkg/js/example/index.html View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/js/lib/js.dart View 2 chunks +2 lines, -50 lines 0 comments Download
M pkg/js/pubspec.yaml View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 2 months ago (2015-10-15 20:35:42 UTC) #2
Jacob
lgtm https://codereview.chromium.org/1411503002/diff/1/pkg/js/README.md File pkg/js/README.md (right): https://codereview.chromium.org/1411503002/diff/1/pkg/js/README.md#newcode13 pkg/js/README.md:13: // Calls to stringify map to `JSON.stringify(obj)`. don't ...
5 years, 2 months ago (2015-10-15 21:19:03 UTC) #3
kevmoo
https://codereview.chromium.org/1411503002/diff/1/pkg/js/README.md File pkg/js/README.md (right): https://codereview.chromium.org/1411503002/diff/1/pkg/js/README.md#newcode13 pkg/js/README.md:13: // Calls to stringify map to `JSON.stringify(obj)`. On 2015/10/15 ...
5 years, 2 months ago (2015-10-15 21:51:09 UTC) #4
kevmoo
5 years, 2 months ago (2015-10-15 21:51:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
045325b32e86e3d9ec0d3e3fd84565203fb805b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698