Issue 1411473004: Drop _DEFAULT_SOURCE and _BSD_SOURCE defines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411473004: Drop _DEFAULT_SOURCE and _BSD_SOURCE defines (Closed)

Created:
5 years, 2 months ago by Roland McGrath

Modified:
5 years, 2 months ago

Reviewers:
Mark Seaborn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Drop _DEFAULT_SOURCE and _BSD_SOURCE defines These are superfluous when using _GNU_SOURCE. BUG= none TEST= trybots R=mseaborn@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/9b7b9d60edadd864efd2b4f64bde2cbb01c10e4f

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -10 lines)			Patch
M	SConstruct	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	build/untrusted.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Seaborn

LGTM. You might want to add "on Linux" in the commit message.

5 years, 2 months ago (2015-10-19 21:46:39 UTC) #2

Roland McGrath

5 years, 2 months ago (2015-10-19 22:30:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b7b9d60edadd864efd2b4f64bde2cbb01c10e4f (presubmit successful).