chrome/browser/chromeos/settings/owner_flags_storage.cc - Issue 1411453004: Componentize internal class FlagsState in flags_ui component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/owner_flags_storage.cc

Issue 1411453004: Componentize internal class FlagsState in flags_ui component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@feature_entry

Patch Set: Fix compilation on Win32 Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/settings/owner_flags_storage.cc

diff --git a/chrome/browser/chromeos/settings/owner_flags_storage.cc b/chrome/browser/chromeos/settings/owner_flags_storage.cc

index a2312648e1968d9ae68697cfdadfb4f66f261431..25d37a89c96e20b881d980089220286e8c724ef1 100644

--- a/chrome/browser/chromeos/settings/owner_flags_storage.cc

+++ b/chrome/browser/chromeos/settings/owner_flags_storage.cc

@@ -57,7 +57,7 @@ bool OwnerFlagsStorage::SetFlags(const std::set<std::string>& flags) {

base::CommandLine command_line(base::CommandLine::NO_PROGRAM);

::about_flags::ConvertFlagsToSwitches(this, &command_line,

- ::about_flags::kNoSentinels);

+ ::flags_ui::kNoSentinels);

Alexei Svitkine (slow) 2015/11/16 21:52:54 Nit: No need for leading ::, since there's no long

sdefresne 2015/11/17 16:28:56 Done.

base::CommandLine::StringVector switches = command_line.argv();

for (base::CommandLine::StringVector::const_iterator it =

switches.begin() + 1;

« chrome/browser/about_flags.cc ('K') | « chrome/browser/chromeos/login/session/user_session_manager.cc ('k') | chrome/browser/ui/webui/flags_ui.cc » ('j') | components/flags_ui.gypi » ('J')