Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: chrome/browser/chrome_browser_main.cc

Issue 1411453004: Componentize internal class FlagsState in flags_ui component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@feature_entry
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main.h" 5 #include "chrome/browser/chrome_browser_main.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 896 matching lines...) Expand 10 before | Expand all | Expand 10 after
907 // affected by experiment flags (--touch-optimized-ui in particular). 907 // affected by experiment flags (--touch-optimized-ui in particular).
908 // On ChromeOS system level flags are applied from the device settings from 908 // On ChromeOS system level flags are applied from the device settings from
909 // the session manager. 909 // the session manager.
910 { 910 {
911 TRACE_EVENT0("startup", 911 TRACE_EVENT0("startup",
912 "ChromeBrowserMainParts::PreCreateThreadsImpl:ConvertFlags"); 912 "ChromeBrowserMainParts::PreCreateThreadsImpl:ConvertFlags");
913 flags_ui::PrefServiceFlagsStorage flags_storage_( 913 flags_ui::PrefServiceFlagsStorage flags_storage_(
914 g_browser_process->local_state()); 914 g_browser_process->local_state());
915 about_flags::ConvertFlagsToSwitches(&flags_storage_, 915 about_flags::ConvertFlagsToSwitches(&flags_storage_,
916 base::CommandLine::ForCurrentProcess(), 916 base::CommandLine::ForCurrentProcess(),
917 about_flags::kAddSentinels); 917 flags_ui::kAddSentinels);
918 } 918 }
919 #endif // !defined(OS_CHROMEOS) 919 #endif // !defined(OS_CHROMEOS)
920 920
921 #if defined(OS_WIN) 921 #if defined(OS_WIN)
922 // This is needed to enable ETW exporting when requested in about:flags. 922 // This is needed to enable ETW exporting when requested in about:flags.
923 // Normally, we enable it in ContentMainRunnerImpl::Initialize when the flag 923 // Normally, we enable it in ContentMainRunnerImpl::Initialize when the flag
924 // is present on the command line but flags in about:flags are converted only 924 // is present on the command line but flags in about:flags are converted only
925 // after this function runs. Note that this starts exporting later which 925 // after this function runs. Note that this starts exporting later which
926 // affects tracing the browser startup. Also, this is only relevant for the 926 // affects tracing the browser startup. Also, this is only relevant for the
927 // browser process, as other processes will get all the flags on their command 927 // browser process, as other processes will get all the flags on their command
(...skipping 922 matching lines...) Expand 10 before | Expand all | Expand 10 after
1850 chromeos::CrosSettings::Shutdown(); 1850 chromeos::CrosSettings::Shutdown();
1851 #endif // defined(OS_CHROMEOS) 1851 #endif // defined(OS_CHROMEOS)
1852 #endif // defined(OS_ANDROID) 1852 #endif // defined(OS_ANDROID)
1853 } 1853 }
1854 1854
1855 // Public members: 1855 // Public members:
1856 1856
1857 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) { 1857 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
1858 chrome_extra_parts_.push_back(parts); 1858 chrome_extra_parts_.push_back(parts);
1859 } 1859 }
OLDNEW
« no previous file with comments | « chrome/browser/about_flags_unittest.cc ('k') | chrome/browser/chromeos/login/session/user_session_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698