Chromium Code Reviews Chromium Code Reviews
Issue 1411453004:
Componentize internal class FlagsState in flags_ui component. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@feature_entry| OLD | NEW |
|---|---|
| 1 # Copyright 2015 The Chromium Authors. All rights reserved. | 1 # Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 { | 5 { |
| 6 'targets': [ | 6 'targets': [ |
| 7 { | 7 { |
| 8 # GN version: //components/flags_ui | 8 # GN version: //components/flags_ui |
| 9 'target_name': 'flags_ui', | 9 'target_name': 'flags_ui', |
| 10 'type': 'static_library', | 10 'type': 'static_library', |
| 11 'include_dirs': [ | 11 'include_dirs': [ |
| 12 '..', | 12 '..', |
| 13 ], | 13 ], |
| 14 'dependencies': [ | 14 'dependencies': [ |
| 15 '../base/base.gyp:base', | 15 '../base/base.gyp:base', |
| 16 '../base/base.gyp:base_prefs', | 16 '../base/base.gyp:base_prefs', |
| 17 '../components/components_strings.gyp:components_strings', | 17 '../components/components_strings.gyp:components_strings', |
| 18 '../ui/base/ui_base.gyp:ui_base', | 18 '../ui/base/ui_base.gyp:ui_base', |
| 19 'flags_ui_switches', | |
| 19 ], | 20 ], |
| 20 'sources': [ | 21 'sources': [ |
| 21 # Note: sources list duplicated in GN build. | 22 # Note: sources list duplicated in GN build. |
| 22 'flags_ui/feature_entry.cc', | 23 'flags_ui/feature_entry.cc', |
| 23 'flags_ui/feature_entry.h', | 24 'flags_ui/feature_entry.h', |
| 24 'flags_ui/feature_entry_macros.h', | 25 'flags_ui/feature_entry_macros.h', |
| 26 'flags_ui/flags_state.cc', | |
| 27 'flags_ui/flags_state.h', | |
| 28 'flags_ui/flags_storage.h', | |
| 25 'flags_ui/flags_ui_constants.cc', | 29 'flags_ui/flags_ui_constants.cc', |
| 26 'flags_ui/flags_ui_constants.h', | 30 'flags_ui/flags_ui_constants.h', |
| 27 'flags_ui/flags_ui_pref_names.cc', | 31 'flags_ui/flags_ui_pref_names.cc', |
| 28 'flags_ui/flags_ui_pref_names.h', | 32 'flags_ui/flags_ui_pref_names.h', |
| 29 'flags_ui/flags_storage.h', | |
| 30 'flags_ui/pref_service_flags_storage.cc', | 33 'flags_ui/pref_service_flags_storage.cc', |
| 31 'flags_ui/pref_service_flags_storage.h', | 34 'flags_ui/pref_service_flags_storage.h', |
| 32 ], | 35 ], |
| 33 }, | 36 }, |
| 37 { | |
| 38 # GN version: //components/flags_ui:switches | |
| 39 'target_name': 'flags_ui_switches', | |
| 40 'type': 'static_library', | |
| 41 'include_dirs': [ | |
| 42 '..', | |
| 43 ], | |
| 44 'sources': [ | |
| 45 # Note: sources list duplicated in GN build. | |
| 46 'flags_ui/flags_ui_switches.cc', | |
| 47 'flags_ui/flags_ui_switches.h', | |
| 48 ], | |
| 49 }, | |
| 50 ], | |
| 51 'conditions': [ | |
| 52 ['OS=="win" and target_arch=="ia32"', { | |
|
Alexei Svitkine (slow)
2015/11/16 21:52:54
Why is this needed? Could use a comment, otherwise
sdefresne
2015/11/17 16:28:56
Done (took the comment from base_win64 target).
| |
| 53 'targets': [ | |
| 54 { | |
| 55 'target_name': 'flags_ui_switches_win64', | |
| 56 'type': 'static_library', | |
| 57 'include_dirs': [ | |
| 58 '..', | |
| 59 ], | |
| 60 'sources': [ | |
| 61 # Note: sources list duplicated in GN build. | |
| 62 'flags_ui/flags_ui_switches.cc', | |
| 63 'flags_ui/flags_ui_switches.h', | |
| 64 ], | |
| 65 }, | |
| 66 'configurations': { | |
| 67 'Common_Base': { | |
| 68 'msvs_target_platform': 'x64', | |
| 69 }, | |
| 70 }, | |
| 71 ], | |
| 72 }], | |
| 34 ], | 73 ], |
| 35 } | 74 } |
| OLD | NEW |
