Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: apps/shell/shell_main_delegate.cc

Issue 141143010: [App Shell] Enable Initialized Logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update commit message Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/shell/shell_main_delegate.cc
diff --git a/apps/shell/shell_main_delegate.cc b/apps/shell/shell_main_delegate.cc
index 9876bec8af00be7e2686a0687c453b6bf5b9383a..78cb8af1b703d14d2833334c4b0dbadb8e195313 100644
--- a/apps/shell/shell_main_delegate.cc
+++ b/apps/shell/shell_main_delegate.cc
@@ -12,6 +12,22 @@
#include "content/public/browser/browser_main_runner.h"
#include "ui/base/resource/resource_bundle.h"
+namespace {
+
+void InitLogging() {
+ base::FilePath log_filename;
+ PathService::Get(base::DIR_EXE, &log_filename);
+ log_filename = log_filename.AppendASCII("app_shell.log");
+ logging::LoggingSettings settings;
+ settings.logging_dest = logging::LOG_TO_ALL;
+ settings.log_file = log_filename.value().c_str();
+ settings.delete_old = logging::DELETE_OLD_LOG_FILE;
+ logging::InitLogging(settings);
+ logging::SetLogItems(true, true, true, true);
+}
+
+} // namepspace
James Cook 2014/01/27 19:21:34 nit: namepspace -> namespace
+
namespace apps {
ShellMainDelegate::ShellMainDelegate() {
@@ -21,7 +37,7 @@ ShellMainDelegate::~ShellMainDelegate() {
}
bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
- // TODO(jamescook): Initialize logging here.
+ InitLogging();
SetContentClient(&content_client_);
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698