[App Shell] Enable Initialized Logging

[App Shell] Enable Initialized Logging

BUG=None
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247615

[Haojian Wu, 2014-01-27 06:41:27]

Please review it. Thanks.

[James Cook, 2014-01-27 19:21:34]

LGTM with one nit

https://codereview.chromium.org/141143010/diff/30001/apps/shell/shell_main_de...
File apps/shell/shell_main_delegate.cc (right):

https://codereview.chromium.org/141143010/diff/30001/apps/shell/shell_main_de...
apps/shell/shell_main_delegate.cc:29: } // namepspace
nit: namepspace -> namespace

[commit-bot: I haz the power, 2014-01-28 04:42:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/141143010/90001

[commit-bot: I haz the power, 2014-01-28 04:42:14]

Failed to apply patch for apps/shell/shell_main_delegate.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file apps/shell/shell_main_delegate.cc
  Hunk #1 succeeded at 13 (offset 1 line).
  Hunk #2 FAILED at 37.
  1 out of 2 hunks FAILED -- saving rejects to file
apps/shell/shell_main_delegate.cc.rej

Patch:       apps/shell/shell_main_delegate.cc
Index: apps/shell/shell_main_delegate.cc
diff --git a/apps/shell/shell_main_delegate.cc
b/apps/shell/shell_main_delegate.cc
index
9876bec8af00be7e2686a0687c453b6bf5b9383a..63d4da1e3a99e21a961c6994d1ad014ab9d9de7d
100644
--- a/apps/shell/shell_main_delegate.cc
+++ b/apps/shell/shell_main_delegate.cc
@@ -12,6 +12,22 @@
 #include "content/public/browser/browser_main_runner.h"
 #include "ui/base/resource/resource_bundle.h"
 
+namespace {
+
+void InitLogging() {
+  base::FilePath log_filename;
+  PathService::Get(base::DIR_EXE, &log_filename);
+  log_filename = log_filename.AppendASCII("app_shell.log");
+  logging::LoggingSettings settings;
+  settings.logging_dest = logging::LOG_TO_ALL;
+  settings.log_file = log_filename.value().c_str();
+  settings.delete_old = logging::DELETE_OLD_LOG_FILE;
+  logging::InitLogging(settings);
+  logging::SetLogItems(true, true, true, true);
+}
+
+}  // namespace
+
 namespace apps {
 
 ShellMainDelegate::ShellMainDelegate() {
@@ -21,7 +37,7 @@ ShellMainDelegate::~ShellMainDelegate() {
 }
 
 bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
-  // TODO(jamescook): Initialize logging here.
+  InitLogging();
   SetContentClient(&content_client_);
   return false;
 }

[commit-bot: I haz the power, 2014-01-28 06:37:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/141143010/110001

[Haojian Wu, 2014-01-28 13:52:43]

On 2014/01/28 06:37:36, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/Hokein.Wu%40gmail.com/141143010/110001

+yoz@, need OWNER's LGTM.

[commit-bot: I haz the power, 2014-01-28 18:36:23]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Yoyo Zhou, 2014-01-28 18:41:21]

LGTM

[commit-bot: I haz the power, 2014-01-29 01:55:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/141143010/110001

[commit-bot: I haz the power, 2014-01-29 02:31:18]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 04:09:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/141143010/110001

[commit-bot: I haz the power, 2014-01-29 05:02:26]

Change committed as 247615