Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/core/html/LinkImport.cpp

Issue 141143006: [import] Cleanup: get rid of ad-hoc state machine. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated to ToT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLLinkElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 void LinkImport::ownerRemoved() 104 void LinkImport::ownerRemoved()
105 { 105 {
106 clear(); 106 clear();
107 } 107 }
108 108
109 void LinkImport::didFinish() 109 void LinkImport::didFinish()
110 { 110 {
111 if (!m_owner) 111 if (!m_owner)
112 return; 112 return;
113 m_owner->scheduleEvent(); 113 // Because didFinish() is called from import's own scheduler in HTMLImportsC ontroller,
114 // we don't need to scheduleEvent() here.
115 m_owner->dispatchEventImmediately();
114 } 116 }
115 117
116 void LinkImport::importChildWasDestroyed(HTMLImportChild* child) 118 void LinkImport::importChildWasDestroyed(HTMLImportChild* child)
117 { 119 {
118 ASSERT(m_child == child); 120 ASSERT(m_child == child);
119 m_child = 0; 121 m_child = 0;
120 clear(); 122 clear();
121 } 123 }
122 124
123 bool LinkImport::isCreatedByParser() const 125 bool LinkImport::isCreatedByParser() const
124 { 126 {
125 return m_owner && m_owner->isCreatedByParser(); 127 return m_owner && m_owner->isCreatedByParser();
126 } 128 }
127 129
128 bool LinkImport::hasLoaded() const 130 bool LinkImport::hasLoaded() const
129 { 131 {
130 return m_child && m_child->isDone() && !m_child->loaderHasError(); 132 return m_child && m_child->isDone() && !m_child->loaderHasError();
131 } 133 }
132 134
133 } // namespace WebCore 135 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLLinkElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698