Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411423008: Exclude tests that takes too long on Valgrind mac. (Closed)

Created:
5 years, 1 month ago by oshima
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude tests that takes too long on Valgrind mac. BUG=542535 Committed: https://crrev.com/a699bbbb7d06ec9ee410e0824cdc78d1d9573638 Cr-Commit-Position: refs/heads/master@{#356649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/base_unittests.gtest_mac.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
oshima
5 years, 1 month ago (2015-10-28 20:55:00 UTC) #2
Lei Zhang
LGTM, thanks!
5 years, 1 month ago (2015-10-28 21:03:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411423008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411423008/1
5 years, 1 month ago (2015-10-28 21:08:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 21:19:07 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 21:20:31 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a699bbbb7d06ec9ee410e0824cdc78d1d9573638
Cr-Commit-Position: refs/heads/master@{#356649}

Powered by Google App Engine
This is Rietveld 408576698