chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc - Issue 1411423006: Simplifed logic of showing/hiding cancel buttons on login screens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc

Issue 1411423006: Simplifed logic of showing/hiding cancel buttons on login screens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fix. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc » ('j') | chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc

diff --git a/chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc b/chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc

index 67bedea6129d087cb2648f7132666a91e84322cf..b50ba9646600fce27b5cf588497a4cf6c488d42f 100644

--- a/chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc

+++ b/chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc

@@ -268,7 +268,7 @@ IN_PROC_BROWSER_TEST_F(LoginUIKeyboardTestWithUsersAndOwner,

CheckGaiaKeyboard();

// Switch back.

- js_checker().Evaluate("$('cancel-add-user-button').click()");

+ js_checker().Evaluate("$('gaia-signin').cancel()");

OobeScreenWaiter(OobeDisplay::SCREEN_ACCOUNT_PICKER).Wait();

EXPECT_EQ(expected_input_methods,