Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1411423006: Simplifed logic of showing/hiding cancel buttons on login screens. (Closed)

Created:
5 years, 2 months ago by dzhioev (left Google)
Modified:
5 years, 2 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplifed logic of showing/hiding cancel buttons on login screens. Screens doesn't rely on HeaderBar to make decisions about showing cancel buttons anymore. Also removed 'cancel add users' header bar button, as it is not used in the new UI. BUG=484514 Committed: https://crrev.com/383b976cead80366f776cb67df1f29874c41c238 Cr-Commit-Position: refs/heads/master@{#355964}

Patch Set 1 #

Patch Set 2 : Small fix. #

Total comments: 4

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411423006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411423006/1
5 years, 2 months ago (2015-10-24 04:19:27 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-24 04:40:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411423006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411423006/20001
5 years, 2 months ago (2015-10-24 05:03:31 UTC) #6
dzhioev (left Google)
Hi, PTAL
5 years, 2 months ago (2015-10-24 05:04:52 UTC) #8
Alexander Alekseev
https://codereview.chromium.org/1411423006/diff/20001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html File chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html (right): https://codereview.chromium.org/1411423006/diff/20001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html#newcode1 chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html:1: <link rel="import" href="chrome://oobe/custom_elements.html"> Why do you need to change ...
5 years, 2 months ago (2015-10-24 05:09:33 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-24 05:23:23 UTC) #11
dzhioev (left Google)
https://codereview.chromium.org/1411423006/diff/20001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html File chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html (right): https://codereview.chromium.org/1411423006/diff/20001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html#newcode1 chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html:1: <link rel="import" href="chrome://oobe/custom_elements.html"> On 2015/10/24 05:09:33, Alexander Alekseev wrote: ...
5 years, 2 months ago (2015-10-24 06:13:53 UTC) #12
Alexander Alekseev
lgtm
5 years, 2 months ago (2015-10-24 06:41:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411423006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411423006/20001
5 years, 2 months ago (2015-10-24 06:41:13 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-24 06:45:48 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-24 06:46:50 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/383b976cead80366f776cb67df1f29874c41c238
Cr-Commit-Position: refs/heads/master@{#355964}

Powered by Google App Engine
This is Rietveld 408576698