Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: ct/res/imp/chromium-perf-runs-sk.html

Issue 1411423003: [CT] Add ability to run unlanded benchmarks on Chromium Perf (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Add documentation link Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ct/res/imp/chromium-perf-runs-sk.html
diff --git a/ct/res/imp/chromium-perf-runs-sk.html b/ct/res/imp/chromium-perf-runs-sk.html
index 10202055f93cf630023a703889aab243036aacce..15c71410f0291db25d0f65e18388a01c09d54b2d 100644
--- a/ct/res/imp/chromium-perf-runs-sk.html
+++ b/ct/res/imp/chromium-perf-runs-sk.html
@@ -123,6 +123,13 @@
<pre>{{chromiumPerfTask.SkiaPatch}}</pre>
</paper-dialog-scrollable>
</paper-dialog>
+
+ <paper-dialog heading="Telemetry Patch" id="{{ getBenchmarkPatchId(index) }}">
+ <paper-dialog-scrollable>
+ <pre>{{chromiumPerfTask.BenchmarkPatch}}</pre>
+ </paper-dialog-scrollable>
+ </paper-dialog>
+
</template>
<table class="runshistory" id="runshistory" cellpadding="5" border="1">
@@ -255,6 +262,9 @@
<template is="dom-if" if="{{chromiumPerfTask.SkiaPatch}}">
<a href="javascript:void(0);" data-index$="{{index}}" data-type="skiaPatch">Skia</a>
</template>
+ <template is="dom-if" if="{{chromiumPerfTask.BenchmarkPatch}}">
+ <a href="javascript:void(0);" data-index$="{{index}}" data-type="benchmarkPatch">Telemetry</a>
+ </template>
</td>
<!-- Task Repeats -->
@@ -343,6 +353,8 @@
that.toggleDialog(that.getBlinkPatchId(id));
} else if (anchor.dataset.type == "skiaPatch") {
that.toggleDialog(that.getSkiaPatchId(id));
+ } else if (anchor.dataset.type == "benchmarkPatch") {
+ that.toggleDialog(that.getBenchmarkPatchId(id));
}
}
var button = sk.findParent(e.target, "PAPER-ICON-BUTTON");
@@ -424,6 +436,10 @@
return "skia_patch" + index;
},
+ getBenchmarkPatchId: function(index) {
+ return "benchmark_patch" + index;
+ },
+
resetPagination: function() {
this.pagination.offset = 0;
this.pagination.size = this.defaultSize;

Powered by Google App Engine
This is Rietveld 408576698