Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: ct/go/ctfe/chromium_perf/chromium_perf.go

Issue 1411423003: [CT] Add ability to run unlanded benchmarks on Chromium Perf (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Add documentation link Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ct/go/db/db.go » ('j') | ct/go/db/db.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ct/go/ctfe/chromium_perf/chromium_perf.go
diff --git a/ct/go/ctfe/chromium_perf/chromium_perf.go b/ct/go/ctfe/chromium_perf/chromium_perf.go
index d4c2dcd253c3640eeeafb6e99de3821699c57f64..1d193201750cb1b9060ff8b87d8094f9c0688a97 100644
--- a/ct/go/ctfe/chromium_perf/chromium_perf.go
+++ b/ct/go/ctfe/chromium_perf/chromium_perf.go
@@ -62,6 +62,7 @@ type DBTask struct {
ChromiumPatch string `db:"chromium_patch"`
BlinkPatch string `db:"blink_patch"`
SkiaPatch string `db:"skia_patch"`
+ BenchmarkPatch string `db:"benchmark_patch"`
Results sql.NullString `db:"results"`
NoPatchRawOutput sql.NullString `db:"nopatch_raw_output"`
WithPatchRawOutput sql.NullString `db:"withpatch_raw_output"`
@@ -88,6 +89,7 @@ func (dbTask DBTask) GetPopulatedAddTaskVars() task_common.AddTaskVars {
taskVars.ChromiumPatch = dbTask.ChromiumPatch
taskVars.BlinkPatch = dbTask.BlinkPatch
taskVars.SkiaPatch = dbTask.SkiaPatch
+ taskVars.BenchmarkPatch = dbTask.BenchmarkPatch
return taskVars
}
@@ -272,6 +274,7 @@ type AddTaskVars struct {
ChromiumPatch string `json:"chromium_patch"`
BlinkPatch string `json:"blink_patch"`
SkiaPatch string `json:"skia_patch"`
+ BenchmarkPatch string `json:"benchmark_patch"`
}
func (task *AddTaskVars) GetInsertQueryAndBinds() (string, []interface{}, error) {
@@ -294,6 +297,7 @@ func (task *AddTaskVars) GetInsertQueryAndBinds() (string, []interface{}, error)
{"chromium_patch", task.ChromiumPatch, db.LONG_TEXT_MAX_LENGTH},
{"blink_patch", task.BlinkPatch, db.LONG_TEXT_MAX_LENGTH},
{"skia_patch", task.SkiaPatch, db.LONG_TEXT_MAX_LENGTH},
+ {"benchmark_patch", task.BenchmarkPatch, db.LONG_TEXT_MAX_LENGTH},
}); err != nil {
return "", nil, err
}
@@ -301,7 +305,7 @@ func (task *AddTaskVars) GetInsertQueryAndBinds() (string, []interface{}, error)
if task.RunInParallel == "True" {
runInParallel = 1
}
- return fmt.Sprintf("INSERT INTO %s (username,benchmark,platform,page_sets,repeat_runs,run_in_parallel, benchmark_args,browser_args_nopatch,browser_args_withpatch,description,chromium_patch,blink_patch,skia_patch,ts_added,repeat_after_days) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?);",
+ return fmt.Sprintf("INSERT INTO %s (username,benchmark,platform,page_sets,repeat_runs,run_in_parallel, benchmark_args,browser_args_nopatch,browser_args_withpatch,description,chromium_patch,blink_patch,skia_patch,benchmark_patch,ts_added,repeat_after_days) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?);",
db.TABLE_CHROMIUM_PERF_TASKS),
[]interface{}{
task.Username,
@@ -317,6 +321,7 @@ func (task *AddTaskVars) GetInsertQueryAndBinds() (string, []interface{}, error)
task.ChromiumPatch,
task.BlinkPatch,
task.SkiaPatch,
+ task.BenchmarkPatch,
task.TsAdded,
task.RepeatAfterDays,
},
« no previous file with comments | « no previous file | ct/go/db/db.go » ('j') | ct/go/db/db.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698