Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1411413009: Only build remoting_me2me_host_archive in chrome_branded build. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only build remoting_me2me_host_archive in chrome_branded build. I had it building unconditionally in #357697. R=sergeyu@chromium.org BUG=512899, 530733 Committed: https://crrev.com/f93ee204a83f28d68036c9eba8e29144183b3260 Cr-Commit-Position: refs/heads/master@{#357979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M remoting/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
5 years, 1 month ago (2015-11-05 01:31:47 UTC) #1
Jamie
lgtm
5 years, 1 month ago (2015-11-05 01:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411413009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411413009/1
5 years, 1 month ago (2015-11-05 01:35:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 02:04:23 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 02:05:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f93ee204a83f28d68036c9eba8e29144183b3260
Cr-Commit-Position: refs/heads/master@{#357979}

Powered by Google App Engine
This is Rietveld 408576698