Fix pointer truncation in 64-bit Windows builds

Fix pointer truncation in 64-bit Windows builds

This was found through a VC++ 2015 Update 1 warning about
pointer truncation. The fix is required for VC++ 2015
compatibility.

Committed: https://crrev.com/744424208bdef3a4b204b8eee8c86187c5951ace
Cr-Commit-Position: refs/heads/master@{#31897}

[brucedawson, 2015-11-07 00:13:31]

Description was changed from

==========
Fix pointer truncation in 64-bit Windows builds

BUG=440500
==========

to

==========
Fix pointer truncation in 64-bit Windows builds

This was found through a VC++ 2015 Update 1 warning about
pointer truncation.

BUG=440500
==========

[brucedawson, 2015-11-07 00:13:31]

brucedawson@chromium.org changed reviewers:
+ jarin@chromium.org

[brucedawson, 2015-11-07 00:13:43]

This looks like a pretty clear pointer truncation bug that could (presumably)
cause crashes, and the fix is simple.

PTAL

[Jarin, 2015-11-09 05:05:07]

LGTM. Good catch, thanks!

https://codereview.chromium.org/1411403011/diff/1/src/base/platform/platform-...
File src/base/platform/platform-win32.cc (right):

https://codereview.chromium.org/1411403011/diff/1/src/base/platform/platform-...
src/base/platform/platform-win32.cc:1151: module_entry.modBaseSize)));
Nit: Fix formatting, please. (If you use git cl format, note that it does not
try to format unchanged lines, so you might have to do a whitespace change here
before running it.)

[brucedawson, 2015-11-09 18:44:33]

Description was changed from

==========
Fix pointer truncation in 64-bit Windows builds

This was found through a VC++ 2015 Update 1 warning about
pointer truncation.

BUG=440500
==========

to

==========
Fix pointer truncation in 64-bit Windows builds

This was found through a VC++ 2015 Update 1 warning about
pointer truncation. The fix is required for VC++ 2015
compatibility.
==========

[brucedawson, 2015-11-09 18:45:52]

> Nit: Fix formatting, please. (If you use git cl format, note that it does not
> try to format unchanged lines, so you might have to do a whitespace change
here
> before running it.)

Done. "git cl format" fixed it - I guess it decided (correctly) that the
excessively
indented line was 'related' to the change.

Committing now.

[brucedawson, 2015-11-09 18:45:58]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2015-11-09 18:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1411403011/#ps20001
(title: "git cl format")

[commit-bot: I haz the power, 2015-11-09 18:46:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411403011/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411403011/20001

[commit-bot: I haz the power, 2015-11-09 19:07:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-09 19:08:23]

Patchset 2 (id:??) landed as
https://crrev.com/744424208bdef3a4b204b8eee8c86187c5951ace
Cr-Commit-Position: refs/heads/master@{#31897}