Chromium Code Reviews| Index: site/user/download.md |
| diff --git a/site/user/download.md b/site/user/download.md |
| index 7c7630a3202b63c1d61d559f84f90ad57bacd054..8c4495ad47e5f6594b59f66988beb3f1b6275516 100644 |
| --- a/site/user/download.md |
| +++ b/site/user/download.md |
| @@ -1,74 +1,76 @@ |
| How to download Skia |
| ==================== |
| -Install gclient and git |
| ------------------------ |
| +Install Depot Tools and Git |
|
hcm
2015/11/09 18:23:56
Depot Tools --> depot_tools (even though it doesn'
hal.canary
2015/11/09 19:45:50
done
|
| +--------------------------- |
| -Follow the instructions on |
| -http://www.chromium.org/developers/how-tos/install-depot-tools to download |
| -chromium's depot_tools (which includes gclient ). |
| +Follow the instructions on [Installing Depot |
| +Tools](http://www.chromium.org/developers/how-tos/install-depot-tools) |
| +to download Chromium's Depot Tools (which includes gclient, git-cl, |
| +and Ninja). |
| -depot_tools will also install git on your system, if it wasn't installed |
| -already. |
| +<!--?prettify lang=sh?--> |
| + |
| + git clone 'https://chromium.googlesource.com/chromium/tools/depot_tools.git' |
| + export PATH="${PWD}/depot_tools:${PATH}" |
| +Depot Tools will also install git on your system, if it wasn't installed |
| +already. |
| Configure git |
|
hcm
2015/11/09 18:23:55
git --> Git to be consistent with above
hal.canary
2015/11/09 19:45:50
done
|
| ------------- |
| +<!--?prettify lang=sh?--> |
| + |
| $ git config --global user.name "Your Name" |
| $ git config --global user.email you@example.com |
| -Download your tree |
| ------------------- |
| +Clone the Skia Repository |
|
hcm
2015/11/09 18:23:56
To be consistent with subheadings in related docs,
hal.canary
2015/11/09 19:45:50
done
|
| +------------------------- |
| + |
| +<!--?prettify lang=sh?--> |
| - $ mkdir skia |
| + $ git clone https://skia.googlesource.com/skia.git |
| $ cd skia |
| - $ gclient config --name . --unmanaged https://skia.googlesource.com/skia.git |
| - $ gclient sync |
| - $ git checkout master |
| -At this point, you have everything you need to build and use Skia! If |
| -you want to make changes, and possibly contribute them back to the Skia |
| -project, read on... |
| +Get Skia's dependencies and generate Ninja Build files |
|
hcm
2015/11/09 18:23:56
lowercase b
hal.canary
2015/11/09 19:45:50
done
|
| +------------------------------------------------------ |
| -Making changes |
| --------------- |
| +<!--?prettify lang=sh?--> |
| -First create a branch for your changes: |
| + $ python bin/sync-and-gyp |
| - $ git checkout --track origin/master -b my_feature master |
| +<!-- |
| + $ python tools/git-sync-deps |
| + $ python ./gyp_skia |
| +--> |
| -After making your changes, create a commit |
| +Compile all Default Targets |
|
hcm
2015/11/09 18:23:55
lowercase d, t
hal.canary
2015/11/09 19:45:50
done
|
| +--------------------------- |
| - $ git add [file1] [file2] ... |
| - $ git commit |
| +<!--?prettify lang=sh?--> |
| -If your branch gets out of date, you will need to update it: |
| + $ ninja -C out/Debug |
| - $ git pull --rebase |
| - $ gclient sync |
| +Execute Skia Tests |
|
hcm
2015/11/09 18:23:55
lowercase t
hal.canary
2015/11/09 19:45:50
done
|
| +------------------ |
| -Uploading changes for review |
| ----------------------------- |
| +[More about Skia correctnest testing tools](../dev/testing/testing) |
|
hcm
2015/11/09 18:23:55
correctness*
hal.canary
2015/11/09 19:45:50
done
|
| - $ git cl upload |
| +<!--?prettify lang=sh?--> |
| -You may have to enter a Google Account username and password to authenticate |
| -yourself to codereview.chromium.org. A free gmail account will do fine, or any |
| -other type of Google account. It does not have to match the email address you |
| -configured using git config --global user.email above, but it can. |
| + $ out/Debug/dm |
| -The command output should include a URL (similar to |
| -https://codereview.chromium.org/111893004/ ) indicating where your changelist |
| -can be reviewed. |
| +Execute Skia Sample Application |
|
hcm
2015/11/09 18:23:56
lowercase s, a
hal.canary
2015/11/09 19:45:50
done
|
| +------------------------------- |
| -Once your change has received an LGTM ("looks good to me"), you can check the |
| -"Commit" box on the codereview page and it will be committed on your behalf. |
| +[More about Skia's SampleApp](sample/sampleapp) |
| -Once your commit has gone in, you should delete the branch containing your |
| -change: |
| +<!--?prettify lang=sh?--> |
| - $ git checkout master |
| - $ git branch -D my_feature |
| + $ out/Debug/SampleApp |
| +At this point, you have everything you need to build and use Skia! If |
| +you want to make changes, and possibly contribute them back to the Skia |
| +project, read [How To Submit a Patch](../dev/contrib/submit). |