Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1411403010: Documentation - Remove references to `gclient sync` (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Documentation - Remove references to `gclient sync` skia.org/user/download - Move sections "Making changes" and "Uploading changes for review" to "How to submit a patch" page - Mention bin/sync-and-gyp skia.org/dev/contrib/submit - Mention branch.autosetuprebase=always to fit with Skia's linear history style. NOTRY=true DOCS_PREVIEW= https://skia.org/user/download?cl=1411403010 DOCS_PREVIEW= https://skia.org/dev/contrib/submit?cl=1411403010 Committed: https://skia.googlesource.com/skia/+/3a210bfd403815bebbc7efabe7bbd373e5a3d8f8

Patch Set 1 #

Patch Set 2 : 2015-11-07 (Saturday) 09:12:55 EST #

Patch Set 3 : 2015-11-07 (Saturday) 10:08:50 EST #

Patch Set 4 : 2015-11-07 (Saturday) 11:37:46 EST #

Patch Set 5 : 2015-11-09 (Monday) 11:38:05 EST #

Total comments: 20

Patch Set 6 : 2015-11-09 (Monday) 14:43:06 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -80 lines) Patch
M site/dev/contrib/submit.md View 1 2 3 4 5 8 chunks +49 lines, -34 lines 0 comments Download
M site/user/download.md View 1 2 3 4 5 1 chunk +47 lines, -46 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hal.canary
ptal
5 years, 1 month ago (2015-11-06 23:18:39 UTC) #3
hcm
https://codereview.chromium.org/1411403010/diff/80001/site/dev/contrib/submit.md File site/dev/contrib/submit.md (right): https://codereview.chromium.org/1411403010/diff/80001/site/dev/contrib/submit.md#newcode18 site/dev/contrib/submit.md:18: $ git config branch.autosetuprebase always As discussed, either note ...
5 years, 1 month ago (2015-11-09 18:23:56 UTC) #7
hcm
On 2015/11/09 18:23:56, hcm wrote: > https://codereview.chromium.org/1411403010/diff/80001/site/dev/contrib/submit.md > File site/dev/contrib/submit.md (right): > > https://codereview.chromium.org/1411403010/diff/80001/site/dev/contrib/submit.md#newcode18 > ...
5 years, 1 month ago (2015-11-09 18:25:51 UTC) #8
hal.canary
https://codereview.chromium.org/1411403010/diff/80001/site/dev/contrib/submit.md File site/dev/contrib/submit.md (right): https://codereview.chromium.org/1411403010/diff/80001/site/dev/contrib/submit.md#newcode18 site/dev/contrib/submit.md:18: $ git config branch.autosetuprebase always On 2015/11/09 at 18:23:55, ...
5 years, 1 month ago (2015-11-09 19:45:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411403010/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411403010/100001
5 years, 1 month ago (2015-11-09 19:46:31 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 19:47:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/3a210bfd403815bebbc7efabe7bbd373e5a3d8f8

Powered by Google App Engine
This is Rietveld 408576698