Issue 1411403002: Cleanups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411403002: Cleanups (Closed)

Created:
5 years, 2 months ago by srdjan

Modified:
5 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	runtime/vm/handles.h	View	5 chunks	+7 lines, -8 lines	0 comments	Download
M	runtime/vm/handles.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/isolate.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/zone.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

srdjan

Also moved stopping of background compilation as first task when shutting isolate.

5 years, 2 months ago (2015-10-19 20:46:18 UTC) #2

srdjan

5 years, 2 months ago (2015-10-19 21:13:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
caedcce4406bde59f016453ff1fb8e39ff5bd52e (presubmit successful).