Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: net/spdy/spdy_test_util_common.h

Issue 1411383005: Initial implementation of RequestPriority-based HTTP/2 dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_test_util_common.h
diff --git a/net/spdy/spdy_test_util_common.h b/net/spdy/spdy_test_util_common.h
index 7a3d272cb9ce9146e6c1403ed6d8495ef2301508..022d02060557e22afbad40360c5f0261475ffb10 100644
--- a/net/spdy/spdy_test_util_common.h
+++ b/net/spdy/spdy_test_util_common.h
@@ -298,7 +298,8 @@ class SpdySessionPoolPeer {
class SpdyTestUtil {
public:
- explicit SpdyTestUtil(NextProto protocol);
+ explicit SpdyTestUtil(NextProto protocol, bool dependency_priorities);
+ ~SpdyTestUtil();
// Add the appropriate headers to put |url| into |block|.
void AddUrlToHeaderBlock(base::StringPiece url,
@@ -552,6 +553,11 @@ class SpdyTestUtil {
SpdyFrame* ConstructWrappedSpdyFrame(const scoped_ptr<SpdyFrame>& frame,
int stream_id);
+ // Called when necessary (when it will affect stream dependency specification
+ // when setting dependencies based on priorioties) to notify the utility
+ // class of stream destruction.
+ void OnStreamDestruction(int stream_id);
+
const SpdyHeaderInfo MakeSpdyHeader(SpdyFrameType type);
// For versions below SPDY4, adds the version HTTP/1.1 header.
@@ -587,6 +593,10 @@ class SpdyTestUtil {
const NextProto protocol_;
const SpdyMajorVersion spdy_version_;
GURL default_url_;
+ bool dependency_priorities_;
+
+ // Track a FIFO list of the stream_id of all created requests by priority.
+ mutable std::map<int, std::vector<int>> priority_to_stream_id_list_;
Bence 2015/11/11 18:47:15 I don't understand why relevant SpdyTestUtil metho
Randy Smith (Not in Mondays) 2015/11/11 23:25:59 Done.
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698