runtime/vm/service_isolate.cc - Issue 1411383004: Enable generation of instruction buffer on precompilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service_isolate.cc

Issue 1411383004: Enable generation of instruction buffer on precompilation (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address more CL concerns Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service_isolate.cc

diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc

index cb92d3a8fa8aebd15f7c33ade78b86b847725810..bd73eb83ddb3e360514f00c6745f101245c35dbf 100644

--- a/runtime/vm/service_isolate.cc

+++ b/runtime/vm/service_isolate.cc

@@ -371,6 +371,11 @@ class RunServiceTask : public ThreadPool::Task {

}

void RunMain(Isolate* I) {

+ if (Dart::IsRunningPrecompiledCode()) {

+ // TODO(24651): Remove this.

+ return;

+ }

StartIsolateScope iso_scope(I);

Thread* T = Thread::Current();

ASSERT(I == T->isolate());

« no previous file with comments | « runtime/vm/cpu_arm64.cc ('k') | no next file » | no next file with comments »